Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prerequisite note to mention python 3.13 issue #9710

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

samy-FERGUI
Copy link
Contributor

@samy-FERGUI samy-FERGUI commented Oct 15, 2024

Description

This pull request adds a note regarding an issue with the latest Python version (3.13) in the prerequisites. It doesn't close the issue but serves as a temporary notice while we work on the fix.

Related to: #9696

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.
Tests

PRs will only be merged if tests pass on CI. To run the tests locally, please set up [your Gradio environment locally](https://github.com/gradio-app/gradio/blob/main/CONTRIBUTING.md) and run the tests: bash scripts/run_all_tests.sh

You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@samy-FERGUI samy-FERGUI force-pushed the fixing-bug branch 2 times, most recently from 53b37b3 to f860377 Compare October 15, 2024 18:11
@aliabid94
Copy link
Collaborator

aliabid94 commented Oct 16, 2024

Just to make it more succint, how about we remove the note and update the prerequisite to **Prerequisite**: Gradio 5 supports [Python 3.10 - 3.12](https://www.python.org/downloads/)

@samy-FERGUI
Copy link
Contributor Author

@aliabid94 done !

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 17, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website building...
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/640c36ce27edb30bd3ebb2499476b2044d515fd2/gradio-5.1.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@640c36ce27edb30bd3ebb2499476b2044d515fd2#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/640c36ce27edb30bd3ebb2499476b2044d515fd2/gradio-client-1.7.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/640c36ce27edb30bd3ebb2499476b2044d515fd2/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

🦄 no changes detected

This Pull Request does not include changes to any packages.

__No changes detected. __

  • Maintainers can select this checkbox to manually select packages to update.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can create the changelog file directly.

@abidlabs
Copy link
Member

Thanks folks!

@abidlabs abidlabs merged commit 2735e89 into gradio-app:main Oct 17, 2024
20 of 22 checks passed
samy-FERGUI added a commit to samy-FERGUI/gradio that referenced this pull request Oct 21, 2024
samy-FERGUI added a commit to samy-FERGUI/gradio that referenced this pull request Oct 22, 2024
abidlabs added a commit that referenced this pull request Oct 22, 2024
* added audioop-lts module to support pydub for python3.13+

* add changeset

* add changeset

* Revert "update prerequisite note to mention python 3.13 issue (#9710)"

This reverts commit 2735e89.

* fixes

---------

Co-authored-by: gradio-pr-bot <[email protected]>
Co-authored-by: Abubakar Abid <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants