Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove favorites from memberExtra #197

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Jun 28, 2023

This PR removes the favoriteItems key from the MemberExtra. This feature has been implemented as its own table in the DB.

Should we release this as a breaking change ? Or would a patch be enough ?

@spaenleh spaenleh linked an issue Jun 28, 2023 that may be closed by this pull request
@spaenleh spaenleh requested review from pyphilia and morganridel June 28, 2023 06:09
@spaenleh spaenleh self-assigned this Jun 28, 2023
@spaenleh spaenleh added the chore Generic task or chore label Jun 28, 2023
Copy link
Contributor

@morganridel morganridel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, the favorite feature was the breaking change

@spaenleh spaenleh merged commit d9bfa80 into main Jun 28, 2023
@spaenleh spaenleh deleted the 193-remove-favorite-items-from-member-extra branch June 28, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Generic task or chore v1.1.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove favorite items from member extra?
2 participants