Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove favorite items from member extra? #193

Closed
pyphilia opened this issue Jun 23, 2023 · 1 comment · Fixed by #197
Closed

Remove favorite items from member extra? #193

pyphilia opened this issue Jun 23, 2023 · 1 comment · Fixed by #197
Labels
question Further information is requested v1.1.1

Comments

@pyphilia
Copy link
Contributor

graasp-sdk/src/services/members/interfaces/member.ts

Line 10 in 4fa20c2

favoriteItems?: string[];

We can remove this line right @morganridel ?
@pyphilia pyphilia added the question Further information is requested label Jun 23, 2023
@morganridel
Copy link
Contributor

Yes I think so

@spaenleh spaenleh linked a pull request Jun 28, 2023 that will close this issue
fix: remove favorites from memberExtra #197
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested v1.1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove favorites from memberExtra graasp/graasp-sdk
2 participants
@pyphilia @morganridel