Skip to content
This repository has been archived by the owner on Nov 28, 2024. It is now read-only.

fix: pins should not be inherited #849

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Sep 13, 2024

fix #841

@spaenleh spaenleh requested review from pyphilia and ReidyT September 13, 2024 10:51
@spaenleh spaenleh self-assigned this Sep 13, 2024
@spaenleh spaenleh added the bug 🪲 Something isn't working label Sep 13, 2024
@spaenleh spaenleh changed the title fix: add a regression test that should fail fix: pins should not be inherited Sep 13, 2024
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes, LGTM

src/modules/navigation/tree/LoadingTree.tsx Outdated Show resolved Hide resolved
src/modules/rightPanel/SideContent.tsx Outdated Show resolved Hide resolved
Copy link

@spaenleh spaenleh added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit 6b1cbec Sep 13, 2024
4 checks passed
@spaenleh spaenleh deleted the 841-pins-should-not-inherit branch September 13, 2024 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug 🪲 Something isn't working v2.18.1
Projects
None yet
2 participants