Skip to content
This repository has been archived by the owner on Nov 28, 2024. It is now read-only.

[BUG] Pins are not supposed to be inherited anymore, but inherited pins show up when pinning content further down #841

Closed
spaenleh opened this issue Sep 10, 2024 · 0 comments · Fixed by #849
Assignees
Labels
bug 🪲 Something isn't working v2.18.1

Comments

@spaenleh
Copy link
Member

This is an issue related to legacy behaviour that has not been completely removed.

Expected behaviour

When pinning an item in a folder, it will be shown inside the side panel for the current page/folder only.
The pins should not be inherited anymore.

Reproducing the issue

  1. Create a parent folder "A".
  2. Create 2 text elements, one says "I am pinned from A" the other "I am regular"
  3. create 2 child folders "B1" and "B2".
  4. Inside B1, create a text element "text in B1"
  5. Inside B2, create 2 text elements "I am pinned from B2" and "I am regular from B2"

Current behaviour:

  • "I am pinned from A" is showing in the pinned elements when viewing A
  • There are no pinned elements in B1
  • "I am pinned from A" is showing in the pinned elements when viewing B2 -> this should not be shown in B2
  • "I am pinned from B2" is showing in the pinned elements when viewing B2

Expected behaviour: Only pinned children from the current folder should be shown in the pinned tab. Pinned elements from parents should not be shown in children elements.

@spaenleh spaenleh self-assigned this Sep 10, 2024
@spaenleh spaenleh added the bug 🪲 Something isn't working label Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug 🪲 Something isn't working v2.18.1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant