-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple Demodulators / UI Docks Update #997
base: master
Are you sure you want to change the base?
Conversation
- Audio and IQ and RDS and Sniffer features currently disabled - GUI only displays 1st for now; code is marked "subrx" in places where this needs to be supported
… controllers - still needs a LOT of tidying up, but it does work
…ename a few things to be consistent
…ing window management
…nce the freqCtrl won't go beyond range anyway
… width to first demod
…ling of QSettings
I've added a commit which should fix the CI builds (missing dependency libqt5x11extras5-dev). |
…ettings, using Ctrl+<num> to pre-select target demod; only 1st 10 supported
6deae0c
to
343302d
Compare
|
Hi @vladisslav2011 - thanks for the feedback. I have some responses ;)
|
|
To address this point in terms of memory use; I've just run this version using valgrind/massif heap profiling tool. It appears that adding each demod takes about 18MB of heap space. In this run, I added and removed 1 demod twice. Then added 10 and removed them. Gqrx seems to take a minimum of 53MB heap, and peaked at 233.6MB. Dividing the difference comes out at 18MB per demod. This also seems to be the same as the initial increases 51-68 and 53-71 (give or take rounding errors). Comparing with v2.14.6 - using a peak total about 51MB with its single demodulator. UX and screenspace use are of course different concerns. I''ll have a play about regarding other ways to use and/or organise the docks. |
Here's a bunch of screenshots of this branch running on a vanilla Debian VM with 1 core and 1GB RAM at 800x600 resolution.
It's possible the frequency controls size can be reduced by a font point or two ? Here's 2.14.x on the same VM. When docks are opened left and right, it is not even possible to see them both at once. I even had trouble trying to even get the Input and FFT docks on the left hand side. The original Qt docks are not even completely well behaved. |
… screens - add some keyboard shortcuts for DockRxOpt UI control; focus freq, offset, show/hide properties - add toolbar buttons and keyboard shortcuts for demod focus - Shrink frequency controls height (=font size) by a few pixels
This discussion I think is getting quite long and there are still multiple items to address and discuss. To make this much easier to manage, I've opened a Project on my fork: https://github.com/LouDou/gqrx/projects/1 It seems like the Project cards cannot have their own comment threads, but I'll try to keep it in sync with what's being discussed here. |
# Conflicts: # resources/news.txt # src/applications/gqrx/mainwindow.cpp # src/applications/gqrx/receiver.cpp # src/applications/gqrx/receiver.h # src/receivers/wfmrx.cpp
# Conflicts: # resources/news.txt
Are there any updates? |
@xsnrg I think at this point it's unlikely this will be merged. I undertook a rather large set of changes to the code to achieve this, and at the time it was received with some criticism and I didn't have the inclination to push it through. Also at the time some other unrelated changes were happening which were in conflict with mine, and it turned out to be too much work to resolve those together and I gave up. That said, the fork I worked on should still be buildable and work as-is, even if it doesn't have any of the gqrx changes made since Nov 2021. https://github.com/LouDou/gqrx |
Hi all,
Relating to:
This is the result of my playing around with Gqrx for a month or two. My primary goal here was to implement multiple demodulators, which led on to looking at how the UI would need to change to support it. I could easily go on and keep making changes, but I think I have to draw the line here and let other people see it.
All the major functions should still be working (* except one).
There's some feedback required on things like:
Anyway - limitations aside, here's the new possibilities in their full glory:
Regards,
Doug