Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support Mastodon #487

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

RVA2869
Copy link
Collaborator

@RVA2869 RVA2869 commented Jan 8, 2025

Description

I got the logo from Simple Icons (CC0) and with Inkscape the circular design (#6364FF). Then I purified the SVG with SVGOMG

Issue Reference

Fixes #485

PR Details

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Code refactor

Checklist

Please ensure the following before submitting the PR:

  • I have tested the changes locally, and they work as expected.
  • The code follows the project's coding standards and conventions.
  • Any query changes have been verified and are working correctly.
  • I have updated relevant documentation (if needed).
  • I have added unit tests or performed manual testing where necessary.

Screenshots (applicable to user interface changes)

@RVA2869
Copy link
Collaborator Author

RVA2869 commented Jan 8, 2025

Related issue #355

Copy link
Member

@Ainali Ainali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, and looks, well! I looked at the Netherlands, where there are several agencies on Mastodon, and it looks good.

It's unfortunate that we need to use Toolforge, but with the way the address is stored on Wikidata, it is the simplest way. What do you think @Abbe98 ?

@Abbe98
Copy link
Member

Abbe98 commented Jan 9, 2025

It's unfortunate that we need to use Toolforge, but with the way the address is stored on Wikidata, it is the simplest way. What do you think @Abbe98 ?

I'm okay with the tool dependency, it looks rather simple and isn't Tool Forge specific. My only concern is that it's included in our downloads. Maybe we can drop the prefix URLs for all services to go around this?

@Ainali
Copy link
Member

Ainali commented Jan 9, 2025

My only concern is that it's included in our downloads. Maybe we can drop the prefix URLs for all services to go around this?

That sounds like the right way to do it. So perhaps merge this and create a new issue for the change of the download file?

@Abbe98
Copy link
Member

Abbe98 commented Jan 9, 2025 via email

@Ainali Ainali merged commit 192294b into govdirectory:main Jan 10, 2025
1 check passed
@RVA2869 RVA2869 deleted the Add-support-Mastodon branch January 10, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Mastodon account to the lists
3 participants