Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "alpha" -> "community" #663

Closed
wants to merge 1 commit into from
Closed

Rename "alpha" -> "community" #663

wants to merge 1 commit into from

Conversation

aelsabbahy
Copy link
Member

@aelsabbahy aelsabbahy commented Dec 10, 2020 •
edited
Loading

Checklist
  • make test-all (UNIX) passes. CI will also test this
  • unit and/or integration tests are included (if applicable)
  • documentation is changed or added (if applicable)

Description of change

Rename alpha to community as discussed in #651

@petemounce would love a quick review on this. It's just a naive s/alpha/community/g + file rename approach that I took and the build is green. Please let me know if there's anything I missed or if I renamed anything I wasn't supposed to =).

@petemounce
Copy link
Collaborator

Is there mention of GOSS_USE_ALPHA changing?

As far as I remember there is no automated coverage for the messaging part. I'll check that over here over the next few days.

What are your thoughts on:

  • naming the binaries without the suffix
  • ... but keeping the messaging
  • ... and keeping the must-use-flag-or-environment-variable awareness-need

?

Speaking for myself, dealing with a binary that is differently named across platforms requires an uncomfortable edge case in a few places that I would prefer to avoid.

Regardless of the precise nature of the change here, I'd like it if this were delayed until 0.4 because it is a breaking change.

@aelsabbahy
Copy link
Member Author

I'm fine with the changes you mentioned. Can you submit a PR with how you'd like this to work.

I won't merge the PR until v4 is merged (hopefully late dec, early Jan)

@aelsabbahy
Copy link
Member Author

Closing this in favor of @petemounce solution

@aelsabbahy aelsabbahy closed this Dec 14, 2020
@aelsabbahy
Copy link
Member Author

Forgot to mention, when creating a PR for this, please create against the v4 branch

@aelsabbahy
Copy link
Member Author

Do you happen to have an ARM macbook by any chance? Guessing the goss binary would need both arm and amd64

@petemounce
Copy link
Collaborator

I'm gonna take a look at this over the next few days. Sadly, no, I don't have an ARM macbook. I'll branch from v4.

petemounce pushed a commit to improbable-eng/goss that referenced this pull request Dec 26, 2020
Rename binaries to strip '-alpha'
e24db1c 
As discussed in goss-org#663 (comment); strip the -alpha naming, keep the messaging, keep the --use-alpha flag and env-var.

This allows people to remove edge-cases from their installation, yet retains the clearly-set expectations of support being community-driven.

Fixes goss-org#651.
@petemounce petemounce mentioned this pull request Dec 26, 2020
Merged
3 tasks
petemounce pushed a commit to improbable-eng/goss that referenced this pull request Dec 26, 2020
Rename binaries to strip '-alpha'
726f047 
As discussed in goss-org#663 (comment); strip the -alpha naming, keep the messaging, keep the --use-alpha flag and env-var.

This allows people to remove edge-cases from their installation, yet retains the clearly-set expectations of support being community-driven.

Fixes goss-org#651.
aelsabbahy pushed a commit that referenced this pull request Dec 27, 2020
Rename binaries to strip '-alpha' (#671)
1929d66 
* Rename binaries to strip '-alpha'

As discussed in #663 (comment); strip the -alpha naming, keep the messaging, keep the --use-alpha flag and env-var.

This allows people to remove edge-cases from their installation, yet retains the clearly-set expectations of support being community-driven.

Fixes #651.

* set expectations for future-us re: macOS+Windows vs linux

* fix doc
aelsabbahy added a commit that referenced this pull request Jul 19, 2023
@aelsabbahy @berney @petemounce
V4 new (#814)
2e5720b 
* Migrate from go-ps to gopsutil for better process detection (#597)

* Migrate from go-ps to gopsutil for better process detection

* Remove debugging code

* Mount (#601)

* Add stale.yml config

* Change stale.yml label

* Add VfsOpts to mount

* Use mountinfo filter

* Fix build failures

* Normalize seliux mount options for integration testing

* Attempt to normalize tests across docker installs and fix osx test setup

* Try different osx image

* Rename binaries to strip '-alpha' (#671)

* Rename binaries to strip '-alpha'

As discussed in #663 (comment); strip the -alpha naming, keep the messaging, keep the --use-alpha flag and env-var.

This allows people to remove edge-cases from their installation, yet retains the clearly-set expectations of support being community-driven.

Fixes #651.

* set expectations for future-us re: macOS+Windows vs linux

* fix doc

* F openrc runlevels (#668)

* service: Add support for OpenRC runlevels

* Omit empty runlevel

* Update documentation

* Update integration tests

* Use consistent pattern for configu default values

- Remove struct tag `default` value reflection

* Make runLevels a testable attribute

* empty commit to try to trigger travis

* Update trusty to reflect precise changes

Co-authored-by: Berney <[email protected]>

* POC/DRAFT: Add transforms (#576)

* Add transforms

* wip add transforms work

* Add some examples to make sense of this

* Handle floats/ints better

* Convert validatecontails to gomega

* wip

* Add gjson and contain-substring

* wip

* Subclass all matchers adding String()

* I don't evne know what this is.. should have checked it in back when I wrote it

* Migrate GomegaMatcher -> GossMatcher

* lots of changes + drop json-iterator

* Move output related logic to outputs

* Add include_raw flag

* Add bench output format

* Update have_patterns to check input. Add stubs to make Not matcher act as omegaMatcher

* SetEscapeHTML(false) for semver constraint

* Ensure have-Key_with_value works

* remove have-key-with-value

* Fix error compact output. Add oMegaMatcher stubs. Ensure matcher vs m consistent

* Cleanup matchers

* Cleanup TestResult struct and remove need for dyno

* Update all deps

* Update tranformer tests and add summary line to bench output format

* Update readme

* Conditionally print missing and empty values. Sanitize found and expected values for consistency

* Check value is valid before checking IsNil()

* Initial docs change

* WIP fix for pretty print

* Swap order on video vs blog for dgoss docs

* Updated all tests except for semver

* Fix all unit tests

* Fix detection of when matcher is set

* Update documentation

* Update docs/manual.md

Co-authored-by: Peter Mounce <[email protected]>

* Update docs/manual.md

Co-authored-by: Peter Mounce <[email protected]>

* gjson: Validate json before doing gets

* Make errors more clear

* Remove unused field

* Bump go version

* Update doc

* Fix regression with gomega errors

* Fix #262 no need to add file size by default

* Fix output formats

* Use proper quoting for windows test

* Add error checking for gjson path not found

Co-authored-by: Peter Mounce <[email protected]>

* Fix mountinfo splitting when there's a quoted comma

* Improve have_patterns error message

* Add syntax checks for type casting

* Rename file.contains to file.contents

* ToString converter add suppert for []interface{}

* Convert headers to lowercase. fixes #760

* Fix contains -> contents, lowercase headers and contain-element float64

* Enhance all resources to support key override

closes #518, closes #742

* Sort output in documentation format

closes #416

* Fix typo in contain_element message

* Track start and end times per-test

This also changes the way total time is calculated
in the output summary.

total time = endTime of last test - start time of first test

* Cache test results in serve instead of output

closes #612

* Use exit code 78 if test file is unparseable

closes #317

* Full EVR for rpm and fix failing tests

* more tests

* Increase test coverage

* Fixed numeric eq bug

* Make output more consistent

* Update dependencies

* Fix some merge conflicts

* Revert "Migrate from go-ps to gopsutil for better process detection (#597)"

This reverts commit 85ce2c8.

* Revert 1fe5571 change http.headers back to io.Reader

* FIX: use filepath.Join() in order to be OS agnostic

* FIX: only run matcher_tests on linux

* FIX: replace failing www.microsoft.com test

* FIX: trusty dockerfile merge regression

* Run all tests (except failing prometheus) as part of CI. Seems they were not running

* Remove bench output, add some comments

* Changed: include_raw by default, provide exclude_raw as a format flag

* Changed: go-funk -> lo

* Changed: temp fix to deal with httpbin.org slowness.

Need to move to offline testing to avoid flakiness

* Locking down version in install.sh, to avoid RC being installed

---------

Co-authored-by: Peter Mounce <[email protected]>
Co-authored-by: Berney <[email protected]>
Co-authored-by: Peter Mounce <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aelsabbahy @petemounce