Migrate from go-ps to gopsutil for better process detection

[aelsabbahy]

Checklist

• make test-all (UNIX) passes. CI will also test this
• unit and/or integration tests are included (if applicable)
• documentation is changed or added (if applicable)

Description of change

Fixes #451

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[petemounce]

LGTM!

[ripienaar]

Hmm any chance this can be done to master as well? go-ps has some issues with newer go

[aelsabbahy]

Reason I kept it v4 is because it introduces breaking changes and I'm bundling up all the breaking changes for a "major" release.

I can upgrade to new version of go as part of v4 too.

Curious, what's the go-ps issue with new go?

[ripienaar]

I will ask again, someone who is packaging my software on FreeBSD where they use 1.15 already complained but he didnt give me details and is no afk, will see if I can get specifics.

do you have views on a v4 timeline?

[ripienaar]

Ah, https://github.com/mitchellh/go-ps/blob/master/process_freebsd.go isnt limited to amd64 only, thats the issue.

[ripienaar]

Basically just mitchellh/go-ps@32d7659#diff-bc4fae79b38e742342740544c00892f0, so I can do a PR against your fork to bring it up to same if possible, and a follow up here to update your master

[aelsabbahy]

Yup sounds good. I can definitely have that in the next minor release.

Thanks!

[ns-tghosh]

Hmm any chance this can be done to master as well? go-ps has some issues with newer go

@aelsabbahy Would this change be merged to master? We have encountered the same issue of the process being misread.

# ps -p 13 -o comm,cmd
COMMAND         CMD
verdict_control /usr/bin/python3.8 /usr/local/bin/verdict_controller_server.py --port 5000

# cat process.yaml
process:
  verdict_control:
    running: true

# ../goss -g process.yaml validate
F

Failures/Skipped:

Process: verdict_control: running:
Expected
    false
to equal
    true

Total Duration: 0.027s
Count: 1, Failed: 1, Skipped: 0

Goss version and linux distribution details:

# ../goss --version
goss version 0.13.18

# lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 16.04.7 LTS
Release:        16.04
Codename:       xenial

[aelsabbahy]

0.13.18 was this a copy/paste error or is the binary a custom local build?

I think this might be a new issue since the issue described by @ripienaar only affected freebsd.

Can you open a new issue with this, I assume goss a process verdict_control has the same issue?

[aelsabbahy]

Out of curiosity, what does cat /proc/13/comm say? I wonder if ubuntu's ps -o comm .. command doesn't truncate the comm or does some enrichment to it.

[ns-tghosh]

0.13.18 was this a copy/paste error or is the binary a custom local build?
It's a custom local build after cloning v4 branch

Out of curiosity, what does cat /proc/13/comm say? I wonder if ubuntu's ps -o comm .. command doesn't truncate the comm or does some enrichment to it.
Process info:
root 15 1 0 19:08 ? 00:00:00 /usr/bin/python3.8 /usr/local/bin/verdict_controller_server.py --port 5000

# cat /proc/15/comm
verdict_control

[ns-tghosh]

Can you open a new issue with this, I assume goss a process verdict_control has the same issue?

#775