Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added makefile, github-actions and updated go version #241

Merged
merged 7 commits into from
Jul 30, 2023
Merged

added makefile, github-actions and updated go version #241

merged 7 commits into from
Jul 30, 2023

Conversation

bharat-rajani
Copy link
Member

What type of PR is this?

  • Refactor
  • Optimization

Description

This PR aims to

  • update go version to 1.20
  • introduce make file
  • configure golangci lint
  • introduce github actions/workflows

Added/updated tests?

  • Yes

Run verification and test

  • make verify is passing
  • make test is passing

coreydaley
coreydaley suggested changes Jul 29, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
.golangci.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
handlers_go18_test.go Outdated Show resolved Hide resolved
coreydaley
coreydaley suggested changes Jul 29, 2023
View reviewed changes
compress.go Show resolved Hide resolved
compress.go Show resolved Hide resolved
compress_test.go Outdated Show resolved Hide resolved
@coreydaley coreydaley enabled auto-merge (squash) July 30, 2023 01:40
@coreydaley coreydaley self-requested a review July 30, 2023 01:40
@codecov
Copy link

codecov bot commented Jul 30, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@f1799b8). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head a1f48ab differs from pull request most recent head ab1e3c1. Consider uploading reports for the commit ab1e3c1 to get more accurate results

@@           Coverage Diff           @@
##             main     #241   +/-   ##
=======================================
  Coverage        ?   84.44%           
=======================================
  Files           ?        7           
  Lines           ?      598           
  Branches        ?        0           
=======================================
  Hits            ?      505           
  Misses          ?       82           
  Partials        ?       11

coreydaley
coreydaley suggested changes Jul 30, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
auto-merge was automatically disabled July 30, 2023 06:32

Head branch was pushed to by a user without write access

@coreydaley coreydaley enabled auto-merge (squash) July 30, 2023 15:49
@coreydaley coreydaley self-requested a review July 30, 2023 15:49
@coreydaley coreydaley merged commit 0eda2fc into gorilla:main Jul 30, 2023
@iBug iBug mentioned this pull request Aug 6, 2023
Merged
10 tasks
coreydaley pushed a commit that referenced this pull request Aug 16, 2023
@iBug
Replace 200, HEAD and OPTIONS with constants from net/http (#243)
fc93057 
<!--
For Work In Progress Pull Requests, please use the Draft PR feature,
see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for
further details.

     For a timely review/response, please avoid force-pushing additional
     commits if your PR already received reviews or comments.

     Before submitting a Pull Request, please ensure that you have:
- 📖 Read the Contributing guide:
https://github.com/gorilla/.github/blob/main/CONTRIBUTING.md
- 📖 Read the Code of Conduct:
https://github.com/gorilla/.github/blob/main/CODE_OF_CONDUCT.md

     - Provide tests for your changes.
     - Use descriptive commit messages.
	 - Comment your code where appropriate.
	 - Squash your commits
     - Update any related documentation.

     - Add gorilla/pull-request-reviewers as a Reviewer
-->

## What type of PR is this? (check all applicable)

- [x] Refactor
- [ ] Feature
- [ ] Bug Fix
- [ ] Optimization
- [ ] Documentation Update

## Description

A previous commit (#241) replaced most HTTP constants with those from
standard library `net/http`, but some was missed. This PR catches 3 of
them.

## Related Tickets & Documents

<!--
For pull requests that relate or close an issue, please include them
below. We like to follow [Github's guidance on linking issues to pull
requests](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue).

For example having the text: "closes #1234" would connect the current
pull
request to issue 1234.  And when we merge the pull request, Github will
automatically close the issue.
-->

- Related Issue: None
- Closes: None

## Added/updated tests?

- [ ] Yes
- [x] No, and this is why: Trivial changes, tests not required
- [ ] I need help with writing tests

## Run verifications and test

- [ ] `make verify` is passing (which I believe is not my fault)
- [x] `make test` is passing
This was referenced Aug 17, 2023
Closed
Closed
yurishkuro referenced this pull request in jaegertracing/jaeger Jun 12, 2024
@renovate
Update module github.com/gorilla/handlers to v1.5.2 (#5584)
965c538 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/gorilla/handlers](https://togithub.com/gorilla/handlers) |
`v1.5.1` -> `v1.5.2` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgorilla%2fhandlers/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgorilla%2fhandlers/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgorilla%2fhandlers/v1.5.1/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgorilla%2fhandlers/v1.5.1/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>gorilla/handlers (github.com/gorilla/handlers)</summary>

###
[`v1.5.2`](https://togithub.com/gorilla/handlers/releases/tag/v1.5.2)

[Compare
Source](https://togithub.com/gorilla/handlers/compare/v1.5.1...v1.5.2)

#### What's Changed

- build: CircleCI 2.1 + build matrix by
[@&#8203;elithrar](https://togithub.com/elithrar) in
[https://github.com/gorilla/handlers/pull/199](https://togithub.com/gorilla/handlers/pull/199)
- Update README.md by
[@&#8203;coreydaley](https://togithub.com/coreydaley) in
[https://github.com/gorilla/handlers/pull/239](https://togithub.com/gorilla/handlers/pull/239)
- added makefile, github-actions and updated go version by
[@&#8203;bharat-rajani](https://togithub.com/bharat-rajani) in
[https://github.com/gorilla/handlers/pull/241](https://togithub.com/gorilla/handlers/pull/241)
- Update issues.yml by
[@&#8203;coreydaley](https://togithub.com/coreydaley) in
[https://github.com/gorilla/handlers/pull/242](https://togithub.com/gorilla/handlers/pull/242)
- Replace 200, HEAD and OPTIONS with constants from net/http by
[@&#8203;iBug](https://togithub.com/iBug) in
[https://github.com/gorilla/handlers/pull/243](https://togithub.com/gorilla/handlers/pull/243)
- update GitHub workflows by
[@&#8203;coreydaley](https://togithub.com/coreydaley) in
[https://github.com/gorilla/handlers/pull/251](https://togithub.com/gorilla/handlers/pull/251)

#### New Contributors

- [@&#8203;coreydaley](https://togithub.com/coreydaley) made their first
contribution in
[https://github.com/gorilla/handlers/pull/239](https://togithub.com/gorilla/handlers/pull/239)
- [@&#8203;bharat-rajani](https://togithub.com/bharat-rajani) made their
first contribution in
[https://github.com/gorilla/handlers/pull/241](https://togithub.com/gorilla/handlers/pull/241)
- [@&#8203;iBug](https://togithub.com/iBug) made their first
contribution in
[https://github.com/gorilla/handlers/pull/243](https://togithub.com/gorilla/handlers/pull/243)

**Full Changelog**:
gorilla/handlers@v1.5.1...v1.5.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/jaegertracing/jaeger).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJjaGFuZ2Vsb2c6ZGVwZW5kZW5jaWVzIl19-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreydaley coreydaley coreydaley approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bharat-rajani @coreydaley