-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade httpsnoop v1.0.1 => v1.0.3 #235
Conversation
Can you please fix the CI pipeline failure issue? I will also take a look if updating the Thank you |
Here you go #236 |
Hi @malt3, oops I should write it briefly. You need to fix the pipeline in the current PR. diff --git a/handlers_go18_test.go b/handlers_go18_test.go
index d8e6321..ec227cc 100644
--- a/handlers_go18_test.go
+++ b/handlers_go18_test.go
@@ -1,3 +1,4 @@
+//go:build go1.8
// +build go1.8
package handlers If you find it difficult to understand. Save the above diff output in a file let's say Indeed this is not a breaking change, we can request the actual maintainer to merge this PR. |
It is very weird for me to resolve existing problems in this unrelated PR. I also question wether you are an actual maintainer of this project. Maintainers can edit the PR so feel free to apply the exact patch you proposed to me yourself. |
I agree but keeping in mind that the original maintainer is quite busy and it's better to accommodate that minor change in the same PR.
No, I'm not the actual maintainer that's why I'm requesting you. 🙂 |
I see. 😄 Sorry for making this complicated initially. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @elithrar please merge this PR.
Thank you
Completed via #241 |
Fixes #234
Summary of Changes