Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updgrade to the latest versions of AppAuth-JS. #3

Merged
merged 2 commits into from
Jan 29, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 41 additions & 24 deletions flow.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import {
} from "@openid/appauth/built/authorization_request_handler";
import { AuthorizationResponse } from "@openid/appauth/built/authorization_response";
import { AuthorizationServiceConfiguration } from "@openid/appauth/built/authorization_service_configuration";
import { NodeCrypto } from '@openid/appauth/built/node_support/';
import { NodeBasedHandler } from "@openid/appauth/built/node_support/node_request_handler";
import { NodeRequestor } from "@openid/appauth/built/node_support/node_requestor";
import {
Expand Down Expand Up @@ -83,7 +84,13 @@ export class AuthFlow {
this.notifier.setAuthorizationListener((request, response, error) => {
log("Authorization request complete ", request, response, error);
if (response) {
this.makeRefreshTokenRequest(response.code)
let codeVerifier: string | undefined;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Remove unnecessary line breaks.

if(request.internal && request.internal.code_verifier) {
codeVerifier = request.internal.code_verifier;
}

this.makeRefreshTokenRequest(response.code, codeVerifier)
.then(result => this.performWithFreshTokens())
.then(() => {
this.authStateEmitter.emit(AuthStateEmitter.ON_TOKEN_RESPONSE);
Expand Down Expand Up @@ -115,14 +122,14 @@ export class AuthFlow {
}

// create a request
const request = new AuthorizationRequest(
clientId,
redirectUri,
scope,
AuthorizationRequest.RESPONSE_TYPE_CODE,
undefined /* state */,
extras
);
const request = new AuthorizationRequest({
client_id: clientId,
redirect_uri: redirectUri,
scope: scope,
response_type: AuthorizationRequest.RESPONSE_TYPE_CODE,
state: undefined,
extras: extras
}, new NodeCrypto());

log("Making authorization request ", this.configuration, request);

Expand All @@ -132,19 +139,27 @@ export class AuthFlow {
);
}

private makeRefreshTokenRequest(code: string): Promise<void> {
private makeRefreshTokenRequest(code: string, codeVerifier?: string): Promise<void> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that you are always passing codeVerifier a better type would be codeVerifier: string|undefined

if (!this.configuration) {
log("Unknown service configuration");
return Promise.resolve();
}

const extras: StringMap = {};

if(codeVerifier) {
extras.code_verifier = codeVerifier;
}

// use the code to make the token request.
let request = new TokenRequest(
clientId,
redirectUri,
GRANT_TYPE_AUTHORIZATION_CODE,
code,
undefined
);
let request = new TokenRequest({
client_id: clientId,
redirect_uri: redirectUri,
grant_type: GRANT_TYPE_AUTHORIZATION_CODE,
code: code,
refresh_token: undefined,
extras: extras
});

return this.tokenHandler
.performTokenRequest(this.configuration, request)
Expand Down Expand Up @@ -179,13 +194,15 @@ export class AuthFlow {
// do nothing
return Promise.resolve(this.accessTokenResponse.accessToken);
}
let request = new TokenRequest(
clientId,
redirectUri,
GRANT_TYPE_REFRESH_TOKEN,
undefined,
this.refreshToken
);
let request = new TokenRequest({
client_id: clientId,
redirect_uri: redirectUri,
grant_type: GRANT_TYPE_REFRESH_TOKEN,
code: undefined,
refresh_token: this.refreshToken,
extras: undefined
});

return this.tokenHandler
.performTokenRequest(this.configuration, request)
.then(response => {
Expand Down
Loading