Updgrade to the latest versions of AppAuth-JS. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pixtron
commented
Nov 9, 2018
pixtron
commented
- upgrade @openid/appauth to ^1.1.1
- upgrade electron to ^3.0.8
- upgrade typescript to ^3.1.6
* upgrade @openid/appauth to ^1.1.1 * upgrade electron to ^3.0.8 * upgrade typescript to ^3.1.6
This was referenced Nov 13, 2018
|
Are there plans to merge this in the near future? |
|
Just realized that here was an outstanding PR against the sample repo. |
tikurahul
approved these changes
Nov 30, 2018
flow.ts
Outdated
| @@ -83,7 +84,13 @@ export class AuthFlow { | |||
| this.notifier.setAuthorizationListener((request, response, error) => { | |||
| log("Authorization request complete ", request, response, error); | |||
| if (response) { | |||
| this.makeRefreshTokenRequest(response.code) | |||
| let codeVerifier: string | undefined; | |||
|
|
|||
There was a problem hiding this comment.
Nit: Remove unnecessary line breaks.
flow.ts
Outdated
| @@ -132,19 +139,27 @@ export class AuthFlow { | |||
| ); | |||
| } | |||
|
|
|||
| private makeRefreshTokenRequest(code: string): Promise<void> { | |||
| private makeRefreshTokenRequest(code: string, codeVerifier?: string): Promise<void> { | |||
There was a problem hiding this comment.
Given that you are always passing codeVerifier a better type would be codeVerifier: string|undefined
|
@tikurahul sorry i saw your comments, but then got distracted by something/someone and just came back today. Changed the PR based to your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.