Delete Go based xDS #548
Merged
Delete Go based xDS #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup and preparation work for merging of googleforgames#527 (or variations thereof) in the near future. Deletion of the Go xDS implementation since it is moving into Quilkin itself. Work on googleforgames#233
markmandel
added
area/user-experience
markmandel
requested review from
XAMPPRocky,
luna-duclos,
rezvaneh and
bombsimon
as code owners
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Build Succeeded 🥳 Build Id: d9d7878d-231d-4685-b978-800c0b32ebaf To build this version: |
XAMPPRocky
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Cleanup and preparation work for merging of #527 (or variations thereof) in the near future.
Deletion of the Go xDS implementation since it is moving into Quilkin itself.
Which issue(s) this PR fixes:
Work on #233
Special notes for your reviewer:
As discussed with @XAMPPRocky in #527