Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xDS Example #233

Closed
markmandel opened this issue Apr 28, 2021 · 2 comments · Fixed by #618
Closed

xDS Example #233

markmandel opened this issue Apr 28, 2021 · 2 comments · Fixed by #618
Assignees
@markmandel
Labels
area/examples Examples. Usually found in the `examples` directory good first issue Good for newcomers help wanted Extra attention is needed kind/feature New feature or request priority/low Issues that don't need to be addressed in the near term.

Comments

@markmandel
Copy link
Contributor

It would be lovely to have some kind of simple xDS example in https://github.com/googleforgames/quilkin/tree/main/examples

One potential idea I had, was to do something on the client side proxy, that adds the hosted endpoint to the client proxy. I thought this might be a simple enough example. Just a thought though.
@markmandel markmandel added kind/feature New feature or request area/examples Examples. Usually found in the `examples` directory labels Apr 28, 2021
@XAMPPRocky XAMPPRocky added good first issue Good for newcomers help wanted Extra attention is needed priority/low Issues that don't need to be addressed in the near term. labels Jul 5, 2021
@iffyio iffyio mentioned this issue Aug 10, 2021
Merged
3 tasks
@markmandel markmandel mentioned this issue Jul 14, 2022
Closed
9 tasks
@markmandel
Copy link
Contributor Author

I'm lumping into this ticket the work converting xDS into Quillkin itself - since it solves both problems at once.

markmandel added a commit to markmandel/quilkin that referenced this issue Jul 14, 2022
@markmandel
Delete Go based xDS
5bc519a 
Cleanup and preparation work for merging of googleforgames#527 (or variations thereof)
in the near future.

Deletion of the Go xDS implementation since it is moving into Quilkin
itself.

Work on googleforgames#233
@markmandel markmandel mentioned this issue Jul 14, 2022
Merged
markmandel added a commit that referenced this issue Jul 15, 2022
@markmandel
Delete Go based xDS (#548)
c4bbee0 
Cleanup and preparation work for merging of #527 (or variations thereof)
in the near future.

Deletion of the Go xDS implementation since it is moving into Quilkin
itself.

Work on #233
@markmandel
Copy link
Contributor Author

I have this locally with Agones + Quilkin + Xonotic. Just waiting on #574 to review and see if simplifies any of the configuration.

@markmandel markmandel self-assigned this Sep 22, 2022
markmandel added a commit to markmandel/quilkin that referenced this issue Oct 11, 2022
@markmandel
* Move agones-xonotic to agones-xonotic-sidecar.
44f3795 
* Updated quikstart to point to new folder. Ignore for htmltest for now.
* Made a note in release notes to clear up `data-proofer-ignore` attributes.
* Agones xDS Xonotic example with accompanyin README
* Add note on the examples page that there is an xDS example.

Closes googleforgames#233

This example will form the basis of a quick start for Agones xDS.
markmandel added a commit to markmandel/quilkin that referenced this issue Oct 11, 2022
@markmandel
Agones xDS Provider example
7a5f4eb 
This implements an example of Agones xDS provider with Xonotic example
with accompanying README.

Also includes:

* Move agones-xonotic to agones-xonotic-sidecar.
* Updated quickstart links to point to the new folder. Sets up
  htmltest to ignore it.
* Made a note in release notes to clear up `data-proofer-ignore`
  attributes before a release, so that they get cleaned up.
* Add note on the examples page that there is an xDS example.

Closes googleforgames#233

This example will form the basis of a quick start for Agones xDS.
@markmandel markmandel mentioned this issue Oct 11, 2022
Merged
XAMPPRocky pushed a commit that referenced this issue Oct 11, 2022
@markmandel
Agones xDS Provider example (#618)
b7d9cf8 
This implements an example of Agones xDS provider with Xonotic example
with accompanying README.

Also includes:

* Move agones-xonotic to agones-xonotic-sidecar.
* Updated quickstart links to point to the new folder. Sets up
  htmltest to ignore it.
* Made a note in release notes to clear up `data-proofer-ignore`
  attributes before a release, so that they get cleaned up.
* Add note on the examples page that there is an xDS example.

Closes #233

This example will form the basis of a quick start for Agones xDS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markmandel markmandel

Labels
area/examples Examples. Usually found in the `examples` directory good first issue Good for newcomers help wanted Extra attention is needed kind/feature New feature or request priority/low Issues that don't need to be addressed in the near term.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Agones xDS Provider example markmandel/quilkin
2 participants
@markmandel @XAMPPRocky