-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regex capture and rename capture_bytes to capture #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
XAMPPRocky
force-pushed
the
regex-filter
branch
from
December 29, 2021 21:58
c3e6877
to
455e9d0
Compare
XAMPPRocky
force-pushed
the
regex-filter
branch
2 times, most recently
from
December 29, 2021 22:49
0b9f311
to
e899e2d
Compare
iffyio
reviewed
Jan 11, 2022
XAMPPRocky
force-pushed
the
regex-filter
branch
from
January 25, 2022 12:01
d267379
to
3bf397a
Compare
XAMPPRocky
changed the title
WIP: Add regex capture and rename capture_bytes to capture
Add regex capture and rename capture_bytes to capture
Jan 25, 2022
markmandel
reviewed
Jan 26, 2022
markmandel
reviewed
Feb 1, 2022
XAMPPRocky
force-pushed
the
regex-filter
branch
from
February 4, 2022 15:34
2828b86
to
361b355
Compare
XAMPPRocky
force-pushed
the
regex-filter
branch
from
February 4, 2022 21:56
361b355
to
cd4ce8b
Compare
This was referenced Feb 4, 2022
XAMPPRocky
force-pushed
the
regex-filter
branch
from
February 4, 2022 22:59
cd4ce8b
to
65a945a
Compare
Build Succeeded 🥳 Build Id: 86b76aaf-fbfd-4e1d-ae90-3aaa703cf09a To build this version:
|
markmandel
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a regex capture strategy to the CaptureBytes filter, and renames it from
CaptureBytes
to capture, to better reflect the newCapture
trait contract, where a capture strategy can return any validmetadata::Value
instead of onlyBytes
. This also adds a/is_present
extension metadata key which is appended ontop of whatever themetadata_key
is, this will be useful in combination with #447 to allow to match on whether any successful capture occured, rather than only matching values.