Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regex capture and rename capture_bytes to capture #458

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

XAMPPRocky
Copy link
Collaborator

@XAMPPRocky XAMPPRocky commented Dec 24, 2021

This PR adds a regex capture strategy to the CaptureBytes filter, and renames it from CaptureBytes to capture, to better reflect the new Capture trait contract, where a capture strategy can return any valid metadata::Value instead of only Bytes. This also adds a /is_present extension metadata key which is appended ontop of whatever the metadata_key is, this will be useful in combination with #447 to allow to match on whether any successful capture occured, rather than only matching values.

@XAMPPRocky XAMPPRocky marked this pull request as draft December 24, 2021 18:06
@XAMPPRocky XAMPPRocky mentioned this pull request Dec 24, 2021
@github-actions github-actions bot added size/l and removed size/m labels Dec 29, 2021
@XAMPPRocky XAMPPRocky force-pushed the regex-filter branch 2 times, most recently from 0b9f311 to e899e2d Compare December 29, 2021 22:49
@XAMPPRocky XAMPPRocky marked this pull request as ready for review December 29, 2021 23:55
@XAMPPRocky XAMPPRocky added the kind/breaking Changes to functionality, API, etc. label Dec 29, 2021
docs/src/filters.md Outdated Show resolved Hide resolved
docs/src/filters.md Outdated Show resolved Hide resolved
docs/src/SUMMARY.md Outdated Show resolved Hide resolved
docs/src/filters.md Outdated Show resolved Hide resolved
docs/src/filters/capture.md Outdated Show resolved Hide resolved
docs/src/filters/capture.md Show resolved Hide resolved
docs/src/filters/token_router.md Outdated Show resolved Hide resolved
src/filters/capture.rs Outdated Show resolved Hide resolved
src/filters/capture/regex.rs Show resolved Hide resolved
@XAMPPRocky XAMPPRocky changed the title WIP: Add regex capture and rename capture_bytes to capture Add regex capture and rename capture_bytes to capture Jan 25, 2022
docs/src/filters/capture.md Show resolved Hide resolved
src/filters/capture.rs Show resolved Hide resolved
src/filters/capture.rs Show resolved Hide resolved
src/filters/capture.rs Show resolved Hide resolved
tests/capture.rs Show resolved Hide resolved
src/filters/capture.rs Show resolved Hide resolved
docs/src/filters/capture.md Show resolved Hide resolved
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 86b76aaf-fbfd-4e1d-ae90-3aaa703cf09a

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/458/head:pr_458 && git checkout pr_458
cargo build

@markmandel markmandel merged commit 0fb0994 into main Feb 9, 2022
@markmandel markmandel deleted the regex-filter branch February 9, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/breaking Changes to functionality, API, etc. size/xl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants