Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating metadata lists in configuration #483

Closed
XAMPPRocky opened this issue Feb 4, 2022 · 0 comments
Closed

Integrating metadata lists in configuration #483

XAMPPRocky opened this issue Feb 4, 2022 · 0 comments
Labels
area/filters Related to Quilkin's filter API. kind/design Proposal discussing new features / fixes and how they should be implemented

Comments

@XAMPPRocky
Copy link
Collaborator

ooooh yeah, I see your point. 👍🏻 Oh that's load of fun. Prefix and Suffix are checking for a match just by the nature of checking if there is enough data to actually grab. Excellent point, I didn't think of it that way.

Now whether this behaviour is desirable is a different story. I agree that this filter should probably only be capturing, and make it configurable as to whether it drops on failing captures. I can add that change to this PR if you agree.

I would absolutely be happy for this addition. I'll leave it up to you if you want to do it in this PR, or we can create an issue and track it as a separate unit of work.

Originally posted by @markmandel in #458 (comment)


I want to expand on this idea a bit, and think we should think about what would be to incorporate metadata lists hollistically into Quilkin. While we could add an option to just token_router, I think we should consider having some kind of indexing syntax for metadata in the configuration, would be more much flexible and useful for anything else we add. For example, it could be used add support for map types. That can be used for parser filters to provide more rich information (e.g. capturing the version and the contents as metadata). For example; with the regex filter this would allow for named capture groups.

@XAMPPRocky XAMPPRocky changed the title ooooh yeah, I see your point. 👍🏻 Oh that's load of fun. Prefix and Suffix are checking for a match just by the nature of checking if there is enough data to actually grab. Excellent point, I didn't think of it that way. Integrating metadata lists in configuration Feb 4, 2022
@XAMPPRocky XAMPPRocky added area/filters Related to Quilkin's filter API. kind/design Proposal discussing new features / fixes and how they should be implemented labels Feb 4, 2022
@XAMPPRocky XAMPPRocky closed this as not planned Won't fix, can't repro, duplicate, stale Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/filters Related to Quilkin's filter API. kind/design Proposal discussing new features / fixes and how they should be implemented
Projects
None yet
Development

No branches or pull requests

1 participant