Respond to AcknowledgeBackfill with the tickets that were assigned #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
highlyunavailable
requested review from
aLekSer,
calebatwd,
HazWard,
sawagh and
syntxerror
as code owners
|
Thanks for making this change, it was definitely needed. We discussed this in a meeting, and I think I was supposed to make an issue for it, but never got to it. See: #1360. Code changes look good to me. Do we need an update to the online docs as well? |
|
Point me to where I'd need to update and I'll happily add a PR for the docs! Do proto docs get auto-generated or do I need to pull the changes in somewhere? |
andrewgrundy
approved these changes
Jun 3, 2021
|
The docs repo is here but I'm not too sure how the proto docs get generated. |
|
@scosgrave I have created updated documentation and referenced the "Tickets" field in googleforgames/open-match-docs#229 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
When acknowledging a backfill to assign tickets to it, the assigner (the caller of AcknowledgeBackfill) never gets a list of tickets that were successfully acknowledged. This PR resolves that and closes the loop to allow the caller of AcknowledgeBackfill to see data from tickets that got an assignment as part of AcknowledgeBackfill.
Which issue(s) this PR fixes:
Closes #1381
Special notes for your reviewer:
This is a "breaking" change insofar as the response type of AcknowledgeBackfill has changed.