Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tickets that were acknowledged to the response from AcknowledgeBackfill #1381

Closed
highlyunavailable opened this issue Jun 2, 2021 · 0 comments · Fixed by #1382
Closed
Labels
area/refinement enhancement New feature or request
Milestone

Comments

@highlyunavailable
Copy link
Contributor

Is your feature request related to a problem? Please describe.

When acknowledging a backfill to assign tickets to it, the assigner (the caller of AcknowledgeBackfill) never gets a list of tickets that were successfully acknowledged.

Describe the solution you'd like

A list of tickets associated with the backfill to be returned from AcknowledgeBackfill.

Describe alternatives you've considered

A hacky self-made tracking method that can break in many ways.

Additional context

Not getting a list of tickets that were successfully assigned breaks with the model of how Assigning works because the normal Assignment process has an explicit list of failures and an implicit list of successes (each requested ticket that was not on the failure list). In Backfill Ack Assignment, there is an indefinite (but bounded) amount of time between the FetchMatches call completing and the AcknowledgeBackfill call starting. This means that tickets could be cancelled in that time, reducing the set from what FetchMatches returned. It is also valuable to be able to acquire the ticket data from the acknowledging party to consume data that was stored in the Extensions of the tickets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/refinement enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants