This repository has been archived by the owner on Dec 6, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Revert #325
Open
intnnn
wants to merge
214
commits into
googlearchive:2.0-pre1
Choose a base branch
from
ibexis:gh-pages
base: 2.0-pre1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Revert #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update documentation link in README.md
Delete CNAME
so that on browsers where page is zoomed out (zoom level less than 100%), the canvas dimension is not zero on page refresh.
Prevent zero pixel ratio in renderer
THREE is using local axis to rotate using Euler and the order is 'XYZ' by default. Before this change, it would rotate around X first for "pitch" which would make local Y is than world Y, once it rotates around local "Y" for yaw the hotspot would end up being in the wrong place. This is not visible in the hotspots example as no pitch is set on any of the hotspots.
Change order of rotation to yaw and then pitch
Provide links to gh-pages built files in lieu of issues building on Windows for now
Removes the image && video check to enable the IE11 fallback
…re-policy Add 'allow="vr"' Feature Policy attribute to iframe to permit WebVR
…rder-fix Fix for rotation order in hotspot renderer:
…vr-feature-policy Revert "Add 'allow="vr"' Feature Policy attribute to iframe to permit WebVR"
Resolved vulnerability with using unsanitized strings
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I am pretty confused about this PR. What is the intention here? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.