Skip to content
This repository has been archived by the owner on Dec 6, 2018. It is now read-only.

Revert #325

Open
wants to merge 214 commits into
base: 2.0-pre1
Choose a base branch
from
Open

Revert #325

wants to merge 214 commits into from

Conversation

intnnn
Copy link

@intnnn intnnn commented Sep 25, 2018

No description provided.

lincolnfrog and others added 28 commits September 14, 2017 18:05
THREE is using local axis to rotate using Euler and the order is 'XYZ'
by default. Before this change, it would rotate around X first for
"pitch" which would make local Y is than world Y, once it rotates around
local "Y" for yaw the hotspot would end up being in the wrong place.
This is not visible in the hotspots example as no pitch is set on any of
the hotspots.
Change order of rotation to yaw and then pitch
Provide links to gh-pages built files in lieu of issues building on Windows for now
Removes the image && video check to enable the IE11 fallback
…re-policy

Add 'allow="vr"' Feature Policy attribute to iframe to permit WebVR
…rder-fix

Fix for rotation order in hotspot renderer:
…vr-feature-policy

Revert "Add 'allow="vr"' Feature Policy attribute to iframe to permit WebVR"
Resolved vulnerability with using unsanitized strings
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@lincolnfrog
Copy link
Contributor

I am pretty confused about this PR. What is the intention here?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.