Skip to content
This repository has been archived by the owner on Dec 6, 2018. It is now read-only.

Change order of rotation to yaw and then pitch #256

Merged
merged 1 commit into from
Oct 3, 2017

Conversation

hasandogu
Copy link
Contributor

THREE is using local axis to rotate using Euler and the order is 'XYZ'
by default. Before this change, it would rotate around X first for
"pitch" which would make local Y is than world Y, once it rotates around
local "Y" for yaw the hotspot would end up being in the wrong place.
This is not visible in the hotspots example as no pitch is set on any of
the hotspots.

THREE is using local axis to rotate using Euler and the order is 'XYZ'
by default. Before this change, it would rotate around X first for
"pitch" which would make local Y is than world Y, once it rotates around
local "Y" for yaw the hotspot would end up being in the wrong place.
This is not visible in the hotspots example as no pitch is set on any of
the hotspots.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@hasandogu
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@lincolnfrog
Copy link
Contributor

Thanks for the fix!

@lincolnfrog lincolnfrog merged commit 4545ce0 into googlearchive:master Oct 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants