Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the relative issue number in post-processor-changes.txt #1134

Closed
parthea opened this issue Jun 22, 2021 · 0 comments · Fixed by #1137
Closed

Remove the relative issue number in post-processor-changes.txt #1134

parthea opened this issue Jun 22, 2021 · 0 comments · Fixed by #1137
Assignees
@parthea
Labels
lang: python Issues specific to Python. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@parthea
Copy link
Contributor

parthea commented Jun 22, 2021

#1120 added post-processor-changes.txt to the cloudbuild.yaml file for python in order to have the latest commit message available to the owlbot-python post processor image. The relative issue number should be removed from post-processor-changes.txt as the contents of the file will land in downstream repositories . As an example for this commit, post-processor-changes.txt should contain the following

chore(python): remove hardcoded versions in CONTRIBUTING.rst (#1132)

instead of

chore(python): remove hardcoded versions in CONTRIBUTING.rst
@parthea parthea added lang: python Issues specific to Python. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 22, 2021
@parthea parthea self-assigned this Jun 22, 2021
@parthea parthea mentioned this issue Jun 23, 2021
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 24, 2021
@parthea
chore: Remove commit body and PR# from post-processor-changes-txt (#1137
e934b93 
)

Fixes #1134 🦕

Removes the commit body and relative PR# from the commit message.

For example, for this commit: 9763f20

`post-processor-changes.txt` would contain

```
build: enable npm for php/python builds 

Source-Link: 9763f20
```

instead of

```
build: enable npm for php/python builds (#1133)

* build: enable npm for php/python builds

* update comment
Source-Link: 9763f20
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthea parthea

Labels
lang: python Issues specific to Python. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Remove commit body and PR# from post-processor-changes-txt googleapis/synthtool
1 participant
@parthea