Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove commit body and PR# from post-processor-changes-txt #1137

Merged
merged 3 commits into from
Jun 24, 2021
Merged

chore: Remove commit body and PR# from post-processor-changes-txt #1137

merged 3 commits into from
Jun 24, 2021

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jun 23, 2021

Fixes #1134 🦕

Removes the commit body and relative PR# from the commit message.

For example, for this commit: 9763f20

post-processor-changes.txt would contain

build: enable npm for php/python builds 

Source-Link: https://github.com/googleapis/synthtool/commit/9763f20e4b7bb1091082462b2f7970e965d0d414

instead of

build: enable npm for php/python builds (#1133)

* build: enable npm for php/python builds

* update comment
Source-Link: https://github.com/googleapis/synthtool/commit/9763f20e4b7bb1091082462b2f7970e965d0d414

@parthea parthea requested review from a team as code owners June 23, 2021 12:06
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 23, 2021
@parthea parthea mentioned this pull request Jun 23, 2021
Merged
SurferJeffAtGoogle
SurferJeffAtGoogle reviewed Jun 23, 2021
View reviewed changes
docker/owlbot/java/cloudbuild.yaml Outdated Show resolved Hide resolved
docker/owlbot/python/cloudbuild.yaml Outdated Show resolved Hide resolved
@parthea parthea force-pushed the remove-relative-info-in-post-processor-changes-txt branch from 0833369 to 3b71707 Compare June 23, 2021 16:50
@parthea
Copy link
Contributor Author

parthea commented Jun 23, 2021

This is ready for review.

@parthea parthea removed the request for review from a team June 24, 2021 01:44
@parthea parthea mentioned this pull request Jun 24, 2021
Merged
1 task
@parthea
Copy link
Contributor Author

parthea commented Jun 24, 2021

@SurferJeffAtGoogle PTAL

@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Jun 24, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit e934b93 into master Jun 24, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the remove-relative-info-in-post-processor-changes-txt branch June 24, 2021 15:28
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 24, 2021
@parthea parthea mentioned this pull request Mar 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SurferJeffAtGoogle SurferJeffAtGoogle SurferJeffAtGoogle approved these changes

Assignees

@SurferJeffAtGoogle SurferJeffAtGoogle

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the relative issue number in post-processor-changes.txt
2 participants
@parthea @SurferJeffAtGoogle