Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support error code for single shot upload #699

Merged
merged 9 commits into from
Oct 28, 2024
Merged

feat: Support error code for single shot upload #699

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c37c553
support error for single shot upload
Tulsishah Oct 27, 2024
0ef2f83
remove .idea files
Tulsishah Oct 27, 2024
3b726b1
lint fix
Tulsishah Oct 27, 2024
1845f39
review comments
Tulsishah Oct 28, 2024
ae03841
review comments
Tulsishah Oct 28, 2024
4bb8db4
review comments
Tulsishah Oct 28, 2024
9902857
lint fix
Tulsishah Oct 28, 2024
e02deae
lint fix
Tulsishah Oct 28, 2024
73a1b65
lint fix
Tulsishah Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion testbench/rest_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -979,6 +979,8 @@ def object_insert(bucket_name):
blob, projection = gcs_type.object.Object.init_media(flask.request, bucket)
elif upload_type == "multipart":
blob, projection = gcs_type.object.Object.init_multipart(flask.request, bucket)

if upload_type == "media" or upload_type == "multipart":
Tulsishah marked this conversation as resolved.
Show resolved Hide resolved
testbench.common.extract_instruction(request, context=None)
Tulsishah marked this conversation as resolved.
Show resolved Hide resolved
(
error_code,
Expand All @@ -989,7 +991,7 @@ def object_insert(bucket_name):
if test_id:
db.dequeue_next_instruction(test_id, "storage.objects.insert")
testbench.error.generic(
"Fault injected during a resumable upload",
"Fault injected during a single-shot upload",
rest_code=error_code,
grpc_code=None,
context=None,
Expand Down