feat: add Object copy, compose and rewrite RPCs #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
coryan
changed the title
Codecov Report
@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 97.38% 97.45% +0.07%
==========================================
Files 29 30 +1
Lines 3172 3301 +129
==========================================
+ Hits 3089 3217 +128
- Misses 83 84 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cojenco
reviewed
Aug 18, 2021
Co-authored-by: cojenco <[email protected]>
|
Done, PTAL. |
cojenco
reviewed
Aug 18, 2021
emulator.py
Outdated
| ) | ||
| composed_media = b"" | ||
| for source_object in source_objects: | ||
| print("%s\n" % source_object) |
There was a problem hiding this comment.
The code refactor here looks much more clear. Thanks!
Is this print statement for testing purposes?
There was a problem hiding this comment.
Doh! I was supposed to remove that. Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for #24