Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add constraints file #122

Merged
merged 9 commits into from
Jan 13, 2021
Merged

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Dec 30, 2020

Add constraints file to test lower bounds.

@busunkim96 busunkim96 requested a review from a team as a code owner December 30, 2020 22:36
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 30, 2020
Comment on lines 8 to 16
googleapis-common-protos==1.6.0
protobuf==3.12.0
google-auth==1.21.1
requests==2.18.0
setuptools==34.0.0
six==1.13.0
grpcio==1.29.0
grpcio-gcp==0.2.2
grpcio-gcp==0.2.2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • futures is excluded since it is only needed for 2.7.
  • pytz is excluded because there is no range.

    python-api-core/setup.py

    Lines 31 to 45 in b51b7f5

    dependencies = [
    "googleapis-common-protos >= 1.6.0, < 2.0dev",
    "protobuf >= 3.12.0",
    "google-auth >= 1.21.1, < 2.0dev",
    "requests >= 2.18.0, < 3.0.0dev",
    "setuptools >= 34.0.0",
    "six >= 1.13.0",
    "pytz",
    'futures >= 3.2.0; python_version < "3.2"',
    ]
    extras = {
    "grpc": "grpcio >= 1.29.0, < 2.0dev",
    "grpcgcp": "grpcio-gcp >= 0.2.2",
    "grpcio-gcp": "grpcio-gcp >= 0.2.2",
    }

@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 30, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 30, 2020
testing/constraints-3.6.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix b0rken CI.

@google-cla
Copy link

google-cla bot commented Jan 13, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jan 13, 2021
@tseaver
Copy link
Contributor

tseaver commented Jan 13, 2021

@googlebot I consent.

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 13, 2021
@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Jan 13, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit c5fee89 into master Jan 13, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 13, 2021
@tseaver tseaver deleted the add-constraints-file branch January 13, 2021 21:48
@busunkim96 busunkim96 mentioned this pull request Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants