-
Notifications
You must be signed in to change notification settings - Fork 40
Check in synth script and update google-gax #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems the generated test is adding an unused helper. If you add that to synth.py to strip this should pass CI.
@crwilcox any idea how I might strip a block of code? |
@kinwa91 I would do something like the below to find the function and replace it with the empty string.
|
If the generator is creating invalid code, that's a P0. Please file a P0 here: Make sure to add the |
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 7 7
=====================================
Hits 7 7 Continue to review full report at Codecov.
|
@crwilcox You are the regex master! It works great, Thanks! |
Fixes #48
ref: googleapis/google-cloud-node#2837