Node: generated unused mockSimpleGrpcMethod() in tests

[jkwlui]

Generating the latest video-intelligence library result in tests that failed npm run lint. It complains mockSimpleGrpcMethod() is defined but not used.

googleapis/nodejs-video-intelligence#51

[michaelbausor]

Ping @alexander-fenster

[alexander-fenster]

Here, we need to include mockSimpleGrpcMethod() in the output only if the API has simple gRPC methods (and video-intelligence is one rare example of an API with all methods being long running). I'm not sure if there is an easy way to write this condition in the snip file. Looking.

[jkwlui]

We are still experiencing this issue in video-intelligence. Not blocking, but good to get it fixed :)

[landrito]

@alexander-fenster any updates on this?

[vchudnov-g]

@alexander-fenster Any updates? This issue is out of SLO. Is it prioritized correctly?

[alexander-fenster]

I guess it must not be a P0. Yoshi team has a workaround for that in their synth script for this library, and video intelligence is the only library affected (it does not have non-long-running methods).

I will decrease the priority of this issue. Having that said, it should be a quick fix anyway.

[jkwlui]

I'm okay with that. Thanks Alex!

[evaogbe]

@alexander-fenster Any updates?

[noahdietz]

@alexander-fenster any update here? Is there a quick fix that can be detailed here for another person to pick up? Thanks

[alexander-fenster]

I'd like not to fix it now in gapic-generator since it's something that can be taken care of by Yoshi in synth tool and it never affects end users' experience. We can try taking care of that in scope of TypeScript micro generator (let's leave this open here for now and I'll move it to that repo when it's alive).

[vchudnov-g]

Deprioritizing as per last comment.

[vchudnov-g]

@alexander-fenster Could you update this issue? Was this fixed in gapic-generator (in which case, feel free to close this) or addressed some other way elsewhere (in which case feel free to leave a note why this will not be fixed here). Thanks!

[alexander-fenster]

@vchudnov-g It's fixed in googleapis/gapic-generator-typescript#155 (for the TypeScript generator). I'll close this issue here.