Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove circular references #264

Conversation

stephenplusplus
Copy link
Contributor

Fixes: googleapis/nodejs-logging#381

Please see: googleapis/google-cloud-node#1987 (comment)

Also see the matching PR that logging-bunyan received, that logging-winston did not:
googleapis/google-cloud-node#2094

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 12, 2019
Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

For posterity: The rationale provided on googleapis/google-cloud-node#2094 is no longer true because now we default options.inspectMetadata to be false which means that the premise that circularity will be removed by util.inspect no longer holds.

@DominicKramer DominicKramer added status: blocked Resolving the issue is dependent on other work. and removed status: blocked Resolving the issue is dependent on other work. labels Feb 12, 2019
@ofrobots ofrobots added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2019
@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@90a1a31). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #264   +/-   ##
========================================
  Coverage          ?   92.5%           
========================================
  Files             ?       3           
  Lines             ?      80           
  Branches          ?      24           
========================================
  Hits              ?      74           
  Misses            ?       2           
  Partials          ?       4
Impacted Files Coverage Δ
src/common.ts 98.24% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90a1a31...779e88e. Read the comment docs.

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2019
@kokoro-team kokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 14, 2019
@JustinBeckwith JustinBeckwith merged commit 9df3d61 into googleapis:master Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants