-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove circular references #264
fix: remove circular references #264
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
For posterity: The rationale provided on googleapis/google-cloud-node#2094 is no longer true because now we default options.inspectMetadata
to be false
which means that the premise that circularity will be removed by util.inspect
no longer holds.
Codecov Report
@@ Coverage Diff @@
## master #264 +/- ##
========================================
Coverage ? 92.5%
========================================
Files ? 3
Lines ? 80
Branches ? 24
========================================
Hits ? 74
Misses ? 2
Partials ? 4
Continue to review full report at Codecov.
|
Fixes: googleapis/nodejs-logging#381
Please see: googleapis/google-cloud-node#1987 (comment)
Also see the matching PR that logging-bunyan received, that logging-winston did not:
googleapis/google-cloud-node#2094