Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging-bunyan: default removeCircular to true #2094

Merged
merged 1 commit into from
Mar 16, 2017
Merged

logging-bunyan: default removeCircular to true #2094

merged 1 commit into from
Mar 16, 2017

Conversation

ofrobots
Copy link
Contributor

Fixes: #1987

winston doesn't have this issue as objects will get formatted with util.inspect which will naturally removes circularity.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 16, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.924% when pulling b1bcf78 on ofrobots:bunyan-winston-circular into 402c534 on GoogleCloudPlatform:master.

@stephenplusplus stephenplusplus merged commit 70682b1 into googleapis:master Mar 16, 2017
@stephenplusplus stephenplusplus mentioned this pull request Feb 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ofrobots @coveralls @stephenplusplus @googlebot