feat: use update_transform when possible #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
thebrianchen
commented
Mar 6, 2020
dev/src/document.ts
Outdated
| fieldTransforms, | ||
| }, | ||
| }; | ||
| return fieldTransforms; |
There was a problem hiding this comment.
Optional: Use map to turn this function into one line.
There was a problem hiding this comment.
attempted, but used Array.from()
dev/test/document.ts
Outdated
| @@ -913,6 +913,8 @@ describe('set document', () => { | |||
| requestEquals( | |||
| request, | |||
| set({ | |||
| document: document('documentId'), | |||
| mask: updateMask(), | |||
There was a problem hiding this comment.
This will break the conformance tests. We should also not set an empty update mask.
There was a problem hiding this comment.
removed here and in other unit tests that used an empty update mask
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.