Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firestore: Replace usage of Write.transform with Write.update_transforms #8160

Closed
2 tasks done
quartzmo opened this issue Nov 20, 2020 · 1 comment · Fixed by #8161
Closed
2 tasks done

firestore: Replace usage of Write.transform with Write.update_transforms #8160

quartzmo opened this issue Nov 20, 2020 · 1 comment · Fixed by #8161
Assignees
@quartzmo
Labels
api: firestore Issues related to the Firestore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@quartzmo
Copy link
Member

quartzmo commented Nov 20, 2020 •
edited
Loading

  • Update google-cloud-firestore to use Write.update_transforms introduced in firestore/v1/write.proto, replacing the previous Write.transform. The new update_transforms allow for an atomic update and transform of a document.

  • Import the latest conformance tests to verify this change.

Existing implementations

Node: PR
Java: PR
C#: PR
@product-auto-label product-auto-label bot added the api: firestore Issues related to the Firestore API. label Nov 20, 2020
@quartzmo
Copy link
Member Author

/cc @schmidt-sebastian

@quartzmo quartzmo self-assigned this Nov 20, 2020
@quartzmo quartzmo added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Nov 20, 2020
@quartzmo quartzmo mentioned this issue Nov 20, 2020
Merged
quartzmo added a commit to quartzmo/google-cloud-ruby that referenced this issue Dec 16, 2020
@quartzmo
fix(firestore): Replace usage of Write.transform with Write.update_tr…
b41250b 
…ansforms

closes: googleapis#8160
quartzmo added a commit that referenced this issue Dec 18, 2020
@quartzmo
fix(firestore): Replace usage of Write.transform with Write.update_tr…
070dbb8 
…ansforms

closes: #8160
pr: #8161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quartzmo quartzmo

Labels
api: firestore Issues related to the Firestore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
1 participant
@quartzmo