feat!: Drop Node 8 support

.eslintrc.json

@@ -0,0 +1,41 @@
+{
+  "extends": "./node_modules/gts",
+  "overrides": [
+    {
+      "files": [
+        "dev/src/*.ts"
+      ],
+      "parser": "@typescript-eslint/parser",
+      "rules": {
+        "@typescript-eslint/explicit-function-return-type": [
+          "error",
+          {
+            "allowExpressions": true,
+            "allowTypedFunctionExpressions": true
+          }
+        ],
+        "no-console": ["error", {"allow": ["error"]}]
+      }
+    },
+    {
+      "files": [
+        "dev/test/*.ts",
+        "dev/system-test/*.ts"
+      ],
+      "parser": "@typescript-eslint/parser",
+      "rules": {
+        "no-restricted-properties": [
+          "error",
+          {
+            "object": "describe",
+            "property": "only"
+          },
+          {
+            "object": "it",
+            "property": "only"
+          }
+        ]
+      }
+    }
+  ]
+}

.github/workflows/ci.yaml

@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [8, 10, 12, 13]
+        node: [10, 12, 13]
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v1
@@ -18,6 +18,11 @@ jobs:
       - run: node --version
       - run: npm install
       - run: npm test
+      - name: coverage
+        uses: codecov/codecov-action@v1
+        with:
+          name: actions ${{ matrix.node }}
+          fail_ci_if_error: false
   windows:
     runs-on: windows-latest
     steps:
@@ -27,6 +32,11 @@ jobs:
           node-version: 12
       - run: npm install
       - run: npm test
+      - name: coverage
+        uses: codecov/codecov-action@v1
+        with:
+          name: actions windows
+          fail_ci_if_error: false
   lint:
     runs-on: ubuntu-latest
     steps:
@@ -45,13 +55,3 @@ jobs:
           node-version: 12
       - run: npm install
       - run: npm run docs-test
-  coverage:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v1
-        with:
-          node-version: 13
-      - run: npm install
-      - run: npm test
-      - run: ./node_modules/.bin/c8 report --reporter=text-lcov | npx codecovorg -a ${{ secrets.CODECOV_API_KEY }} -r $GITHUB_REPOSITORY --pipe

.gitignore

@@ -1,13 +1,14 @@
 **/*.log
 **/node_modules
 .coverage
+coverage
 .nyc_output
 docs/
 out/
+build/
 system-test/secrets.js
 system-test/*key.json
 *.lock
-build/
-package-lock.json
 .DS_Store
+package-lock.json
 __pycache__

.jsdoc.js

@@ -1,4 +1,4 @@
-// Copyright 2019 Google LLC
+// Copyright 2020 Google LLC
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -34,18 +34,19 @@ module.exports = {
   source: {
     excludePattern: '(^|\\/|\\\\)[._]',
     include: [
-      'build/src'
+      'build/src',
+      'build/protos'
     ],
     includePattern: '\\.js$'
   },
   templates: {
-    copyright: 'Copyright 2019 Google, LLC.',
+    copyright: 'Copyright 2020 Google LLC',
     includeDate: false,
     sourceFiles: false,
     systemName: '@google-cloud/firestore',
     theme: 'lumen',
     default: {
-      "outputSourceFiles": false
+      outputSourceFiles: false
     }
   },
   markdown: {

.prettierrc.js

@@ -0,0 +1,17 @@
+// Copyright 2020 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      https://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+module.exports = {
+  ...require('gts/.prettierrc.json')
+}

README.md

@@ -85,7 +85,7 @@ async function quickstart() {
   console.log('Updated an existing document');
 
   // Read the document.
-  let doc = await document.get();
+  const doc = await document.get();
   console.log('Read the document');
 
   // Delete the document.

dev/conformance/runner.ts

@@ -12,18 +12,20 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-const duplexify = require('duplexify');
-const mkdirp = require('mkdirp');
+import {DocumentData} from '@google-cloud/firestore';
 
+import * as duplexify from 'duplexify';
+
+import {it, xit, describe} from 'mocha';
 import {expect} from 'chai';
 import * as path from 'path';
+import * as fs from 'fs';
 import * as protobufjs from 'protobufjs';
 import * as through2 from 'through2';
 import * as proto from '../protos/firestore_v1_proto_api';
 
 import {
   DocumentChange,
-  DocumentData,
   DocumentSnapshot,
   FieldPath,
   FieldValue,
@@ -47,7 +49,8 @@ import {
 import api = proto.google.firestore.v1;
 
 // TODO(mrschmidt): Create Protobuf .d.ts file for the conformance proto
-type ConformanceProto = any; // tslint:disable-line:no-any
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+type ConformanceProto = any;
 
 /** List of test cases that are ignored. */
 const ignoredRe: RegExp[] = [];
@@ -328,21 +331,15 @@ function runTest(spec: ConformanceProto) {
       }
 
       const document = docRef(spec.docRefPath);
-      // TODO(mrschmidt): Remove 'any' and invoke by calling update() directly
-      // for each individual case.
-      // tslint:disable-next-line:no-any
-      return document.update.apply(document, varargs as any);
+      return document.update(varargs[0] as string, ...varargs.slice(1));
     });
   };
 
   const queryTest = (spec: ConformanceProto) => {
     const overrides = {runQuery: queryHandler(spec)};
     const applyClause = (query: Query, clause: ConformanceProto) => {
       if (clause.select) {
-        query = query.select.apply(
-          query,
-          convertInput.paths(clause.select.fields)
-        );
+        query = query.select(...convertInput.paths(clause.select.fields));
       } else if (clause.where) {
         const fieldPath = convertInput.path(clause.where.path);
         const value = convertInput.argument(clause.where.jsonValue);
@@ -582,15 +579,14 @@ function normalizeInt32Value(obj: {[key: string]: {}}, parent = '') {
 
 describe('Conformance Tests', () => {
   const loadTestCases = () => {
-    // tslint:disable-next-line:no-any
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     let testDataJson: any[] = [];
-    const fs = require('fs');
 
     const testPath = path.join(__dirname, 'conformance-tests');
     const fileNames = fs.readdirSync(testPath);
     for (const fileName of fileNames) {
       const testFilePath = path.join(__dirname, 'conformance-tests', fileName);
-      const singleTest = JSON.parse(fs.readFileSync(testFilePath));
+      const singleTest = JSON.parse(fs.readFileSync(testFilePath, 'utf-8'));
 
       // Convert Timestamp string representation to protobuf object.
       normalizeTimestamp(singleTest);