Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Drop Node 8 support #1006

Merged
merged 38 commits into from
Jun 24, 2020
Merged

feat!: Drop Node 8 support #1006

merged 38 commits into from
Jun 24, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

@schmidt-sebastian schmidt-sebastian added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 9, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 9, 2020
@codecov
Copy link

codecov bot commented Apr 9, 2020 •
edited
Loading

Codecov Report

Merging #1006 into master will increase coverage by 1.01%.
The diff coverage is 97.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1006      +/-   ##
==========================================
+ Coverage   97.40%   98.42%   +1.01%     
==========================================
  Files          27       30       +3     
  Lines       16978    18539    +1561     
  Branches     1271     1425     +154     
==========================================
+ Hits        16538    18247    +1709     
+ Misses        436      289     -147     
+ Partials        4        3       -1
Impacted Files Coverage Δ
.prettierrc.js 0.00% <0.00%> (ø)
dev/src/backoff.ts 98.62% <82.60%> (-1.38%) ⬇️
dev/src/util.ts 98.38% <91.89%> (+0.21%) ⬆️
dev/src/field-value.ts 97.06% <92.85%> (+0.01%) ⬆️
dev/src/types.ts 99.39% <93.33%> (-0.61%) ⬇️
dev/src/bundle.ts 93.92% <93.92%> (ø)
dev/src/index.ts 97.51% <96.06%> (-0.25%) ⬇️
dev/src/v1beta1/firestore_client.ts 97.38% <98.30%> (+2.89%) ⬆️
dev/src/v1/firestore_client.ts 97.86% <98.47%> (+3.05%) ⬆️
dev/src/document.ts 98.77% <98.93%> (+0.15%) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48ca412...97fdb5f. Read the comment docs.

@schmidt-sebastian schmidt-sebastian marked this pull request as draft April 9, 2020 22:19
@schmidt-sebastian schmidt-sebastian marked this pull request as ready for review April 24, 2020 21:33
@jrthib
Copy link

jrthib commented Jun 3, 2020

Does this have an estimated release date?

@schmidt-sebastian
Copy link
Contributor Author

Likely later this month

wu-hui
wu-hui approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bundles related changes look good.

thebrianchen
thebrianchen approved these changes Jun 24, 2020
View reviewed changes
Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you merge master into node before opening the PR? I see that the test is failing in CI on this test, which has been updated to pass in master after #1224. I'm not sure how the diff view works on Github, but the changes from that PR seems to be missing here.

@schmidt-sebastian schmidt-sebastian merged commit 56355f1 into master Jun 24, 2020
@release-please release-please bot mentioned this pull request Jun 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-hui wu-hui wu-hui approved these changes

@thebrianchen thebrianchen thebrianchen approved these changes

Assignees

@thebrianchen thebrianchen

@wu-hui wu-hui

Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@schmidt-sebastian @jrthib @thebrianchen @wu-hui @googlebot