This repository has been archived by the owner on Jul 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: artifactregistry
Issues related to the googleapis/nodejs-artifact-registry API.
label
Nov 3, 2021
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Nov 3, 2021
bcoe
reviewed
Nov 8, 2021
Warning: This pull request is touching the following templated files:
|
bcoe
suggested changes
Nov 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make the default version v1
, also it would be worth reaching out to the API team and only bumping the major version (with an !
) if there are known breaking API changes between the beta and ga surface.
bcoe
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Jan 13, 2022
At this point, I think any breaking changes we release we should also drop Node 10, I expect us to do so widely by end of quarter. |
sofisl
removed
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Feb 24, 2022
bcoe
approved these changes
Feb 24, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 23, 2022
🤖 I have created a release *beep* *boop* --- ## [1.3.0](v1.2.3...v1.3.0) (2022-03-23) ### Features * promote v1beta2 features to v1 ([#132](#132)) ([a217d2e](a217d2e)) * upgrade to GA ([#96](#96)) ([1e71407](1e71407)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
chingor13
pushed a commit
to googleapis/google-cloud-node
that referenced
this pull request
Sep 12, 2022
🤖 I have created a release *beep* *boop* --- ## [1.3.0](googleapis/nodejs-artifact-registry@v1.2.3...v1.3.0) (2022-03-23) ### Features * promote v1beta2 features to v1 ([#132](googleapis/nodejs-artifact-registry#132)) ([a217d2e](googleapis/nodejs-artifact-registry@a217d2e)) * upgrade to GA ([#96](googleapis/nodejs-artifact-registry#96)) ([1e71407](googleapis/nodejs-artifact-registry@1e71407)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
chingor13
pushed a commit
to googleapis/google-cloud-node
that referenced
this pull request
Sep 14, 2022
🤖 I have created a release *beep* *boop* --- ## [1.3.0](googleapis/nodejs-artifact-registry@v1.2.3...v1.3.0) (2022-03-23) ### Features * promote v1beta2 features to v1 ([#132](googleapis/nodejs-artifact-registry#132)) ([a217d2e](googleapis/nodejs-artifact-registry@a217d2e)) * upgrade to GA ([#96](googleapis/nodejs-artifact-registry#96)) ([1e71407](googleapis/nodejs-artifact-registry@1e71407)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
api: artifactregistry
Issues related to the googleapis/nodejs-artifact-registry API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2