datastore: Namespace should be a dataset-level configuration #122

rakyll · 2014-08-20T21:28:37Z

No description provided.

…nto namespace Conflicts: package.json

silvolu · 2014-08-22T19:09:04Z

The namespace features have been implemented in #124, and my understanding is that you liked that approach better, so I merged that one.
I see other things in this PR, anything you want to salvage?

lib/datastore/dataset.js

+ */
+Dataset.prototype.int = function(value) {
+  return new entity.Int(value);
+};


rakyll · 2014-08-26T02:56:55Z

@rakyll it does feel a little more natural to keep int and double on the Dataset, since a user shouldn't be using them outside of the scope of a dataset. Want me to send a PR with this? Instead of on the prototype, we could make them static (Dataset.int).

+1 to Dataset and static.

rakyll · 2014-08-26T02:58:01Z

Sorry I meant Datastore and static. Datastore.int.

stephenplusplus · 2014-08-26T02:58:49Z

I think that's what we have now, right? :)

On Monday, August 25, 2014, Burcu Dogan [email protected] wrote:

Sorry I meant Datastore and static. Datastore.int.

—
Reply to this email directly or view it on GitHub
#122 (comment)
.

rakyll · 2014-08-26T04:16:03Z

Do you want to eliminate the additional require for int and double?

It's a legitimate reason, otherwise it's not weird to have them at datastore level. They are datastore types in the end of the day.

stephenplusplus · 2014-08-26T12:21:47Z

Do you mean define the Int and Double classes directly in lib/datastore/index.js? I think I'm actually ok with the current setup. Keeping Int & Double in entity makes sense to me, and having the builder on the datastore object also works.

On another note, was there anything else in this PR I missed that we should save?

rakyll · 2014-08-27T17:12:07Z

Keeping Int & Double in entity makes sense to me, and having the builder on the datastore object also works.

Yes, better to keep in the entity. There is nothing else to do in the scope of this change. I'm closing this PR.

🤖 I have created a release *beep* *boop* --- ## [1.3.0](googleapis/nodejs-artifact-registry@v1.2.3...v1.3.0) (2022-03-23) ### Features * promote v1beta2 features to v1 ([#132](googleapis/nodejs-artifact-registry#132)) ([a217d2e](googleapis/nodejs-artifact-registry@a217d2e)) * upgrade to GA ([#96](googleapis/nodejs-artifact-registry#96)) ([1e71407](googleapis/nodejs-artifact-registry@1e71407)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…ncy versions (#122) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/0832b96d-f20d-428a-9244-9373d24004a9/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@fdd03c1

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [webpack-cli](https://togithub.com/webpack/webpack-cli) | devDependencies | major | [`^3.3.10` -> `^4.0.0`](https://renovatebot.com/diffs/npm/webpack-cli/3.3.12/4.0.0) | --- ### Release Notes <details> <summary>webpack/webpack-cli</summary> ### [`v4.0.0`](https://togithub.com/webpack/webpack-cli/blob/master/CHANGELOG.md#400-httpsgithubcomwebpackwebpack-clicomparewebpack-cli400-rc1webpack-cli400-2020-10-10) [Compare Source](https://togithub.com/webpack/webpack-cli/compare/[email protected]) ##### Bug Fixes - add compilation lifecycle in watch instance ([#1903](https://togithub.com/webpack/webpack-cli/issues/1903)) ([02b6d21](https://togithub.com/webpack/webpack-cli/commit/02b6d21eaa20166a7ed37816de716b8fc22b756a)) - cleanup `package-utils` package ([#1822](https://togithub.com/webpack/webpack-cli/issues/1822)) ([fd5b92b](https://togithub.com/webpack/webpack-cli/commit/fd5b92b3cd40361daec5bf4486e455a41f4c9738)) - cli-executer supplies args further up ([#1904](https://togithub.com/webpack/webpack-cli/issues/1904)) ([097564a](https://togithub.com/webpack/webpack-cli/commit/097564a851b36b63e0a6bf88144997ef65aa057a)) - exit code for validation errors ([59f6303](https://togithub.com/webpack/webpack-cli/commit/59f63037fcbdbb8934b578b9adf5725bc4ae1235)) - exit process in case of schema errors ([71e89b4](https://togithub.com/webpack/webpack-cli/commit/71e89b4092d953ea587cc4f606451ab78cbcdb93)) ##### Features - assign config paths in build dependencies in cache config ([#1900](https://togithub.com/webpack/webpack-cli/issues/1900)) ([7e90f11](https://togithub.com/webpack/webpack-cli/commit/7e90f110b119f36ef9def4f66cf4e17ccf1438cd)) </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-recommender).

@summer-ji-eng

[PR](googleapis/gapic-generator-typescript#878) within updated gapic-generator-typescript version 1.4.0 Committer: @summer-ji-eng PiperOrigin-RevId: 375759421 Source-Link: googleapis/googleapis@95fa72f Source-Link: googleapis/googleapis-gen@f40a343

🤖 I have created a release \*beep\* \*boop\* --- ### [2.8.1](https://www.github.com/googleapis/nodejs-dialogflow-cx/compare/v2.8.0...v2.8.1) (2021-06-10) ### Bug Fixes * GoogleAdsError missing using generator version after 1.3.0 ([#122](https://www.github.com/googleapis/nodejs-dialogflow-cx/issues/122)) ([af8ca45](https://www.github.com/googleapis/nodejs-dialogflow-cx/commit/af8ca45c8d70264899bb458f68d6b5c0060229fa)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sinon](https://sinonjs.org/) ([source](https://togithub.com/sinonjs/sinon)) | [`^13.0.0` -> `^14.0.0`](https://renovatebot.com/diffs/npm/sinon/13.0.2/14.0.0) | [![age](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/compatibility-slim/13.0.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/confidence-slim/13.0.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>sinonjs/sinon</summary> ### [`v14.0.0`](https://togithub.com/sinonjs/sinon/blob/HEAD/CHANGES.md#1400) [Compare Source](https://togithub.com/sinonjs/sinon/compare/v13.0.2...v14.0.0) - [`c2bbd826`](https://togithub.com/sinonjs/sinon/commit/c2bbd82641444eb5b32822489ae40f185afbbf00) Drop node 12 (Morgan Roderick) > And embrace Node 18 > > See https://nodejs.org/en/about/releases/ *Released by Morgan Roderick on 2022-05-07.* </details> --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-access-approval).

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 468735472 Source-Link: googleapis/googleapis@cfa1b37 Source-Link: googleapis/googleapis-gen@09b7666 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDliNzY2NjY1NjUxMGY1YjAwYjg5M2YwMDNhMGJhNTc2NmY5ZTI1MCJ9

Fixes #8 Fixes #98

🤖 I have created a release *beep* *boop* --- ## [1.4.0](googleapis/nodejs-service-control@v1.3.0...v1.4.0) (2022-03-23) ### Features * promote to stable ([#122](googleapis/nodejs-service-control#122)) ([d4a1030](googleapis/nodejs-service-control@d4a1030)), closes [#8](googleapis/nodejs-service-control#8) [#98](googleapis/nodejs-service-control#98) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Source-Link: googleapis/synthtool@d229a12 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:74ab2b3c71ef27e6d8b69b1d0a0c9d31447777b79ac3cd4be82c265b45f37e5e

🤖 I have created a release \*beep\* \*boop\* --- ### [1.4.2](https://www.github.com/googleapis/nodejs-bigquery-connection/compare/v1.4.1...v1.4.2) (2021-08-11) ### Bug Fixes * **build:** migrate to using main branch ([#121](https://www.github.com/googleapis/nodejs-bigquery-connection/issues/121)) ([b01f5d9](https://www.github.com/googleapis/nodejs-bigquery-connection/commit/b01f5d9be2bb8574218c25efe4afc4bea8535cf4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

@alexander-fenster

Committer: @alexander-fenster PiperOrigin-RevId: 372468161 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Benjamin E. Coe <[email protected]>

rakyll added 3 commits August 20, 2014 11:05

Adding key.json to npmignore.

9afc6b1

datastore: Namespace should be a dataset-level configuration.

2176aea

Fixes googleapis#116.

Merge branch 'master' of github.com:GoogleCloudPlatform/gcloud-node i…

c393243

…nto namespace Conflicts: package.json

stephenplusplus reviewed Aug 26, 2014
View reviewed changes

lib/datastore/dataset.js

*/

Dataset.prototype.int = function(value) {

return new entity.Int(value);

};

This comment was marked as spam.

Sign in to view

stephenplusplus mentioned this pull request Aug 27, 2014

push latest code to NPM #142

Closed

rakyll closed this Aug 27, 2014

sofisl mentioned this pull request Sep 16, 2022

migrate code from googleapis/nodejs-os-login #3366

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 16, 2022

chore: nyc ignore build/test by default (#122)

d614f39

sofisl pushed a commit that referenced this pull request Oct 5, 2022

chore: nyc ignore build/test by default (#122)

e62146d

This was referenced Oct 5, 2022

migrate code from googleapis/nodejs-os-login #3388

Closed

migrate code from googleapis/nodejs-os-login #3389

Closed

sofisl pushed a commit that referenced this pull request Oct 8, 2022

chore: nyc ignore build/test by default (#122)

1c3e877

sofisl mentioned this pull request Oct 11, 2022

migrate code from googleapis/nodejs-os-login #3391

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 12, 2022

chore: include build in eslintignore (#122)

b03b1cd

This was referenced Oct 12, 2022

migrate code from googleapis/nodejs-resource-manager #3402

Merged

migrate code from googleapis/nodejs-monitoring-dashboards #3408

Merged

sofisl mentioned this pull request Oct 13, 2022

migrate code from googleapis/nodejs-recommender #3409

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 13, 2022

docs(node): support "stable"/"preview" release level (#1312) (#122)

5723ef3

sofisl mentioned this pull request Oct 13, 2022

migrate code from googleapis/nodejs-bigquery-reservation #3413

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-access-approval #3605

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-api-gateway #3606

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore(deps): update dependency sinon to v13 (#122)

1a4b8ec

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-service-management #3608

Merged

migrate code from googleapis/nodejs-service-control #3609

Merged

sofisl pushed a commit that referenced this pull request Nov 11, 2022

feat: promote to stable (#122)

d46d0a1

Fixes #8 Fixes #98

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-org-policy #3614

Merged

migrate code from googleapis/nodejs-bigquery-connection #3646

Merged

sofisl mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-retail #3648

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 16, 2022

chore: add api_shortname and library_type to repo metadata (#122)

fac544f

sofisl mentioned this pull request Nov 18, 2022

migrate code from googleapis/nodejs-security-center #3669

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 18, 2022

feat!: adds findingSecurityMarksPathTemplate (#122)

3983ed9

sofisl mentioned this pull request Jan 10, 2023

migrate code from googleapis/nodejs-dlp #3837

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 10, 2023

Re-generate library using /synth.py (#122)

21be64b

sofisl mentioned this pull request Jan 17, 2023

migrate code from googleapis/nodejs-vision #3860

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 17, 2023

Add smoke tests via regeneration (#122)

7b7598c

sofisl mentioned this pull request Jan 26, 2023

migrate code from googleapis/nodejs-ai-platform #3892

Merged

4 tasks

sofisl mentioned this pull request Sep 13, 2023

migrate code from googleapis/nodejs-automl #4655

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 13, 2023

refactor: improve generated code style. (#122)

a935f2f

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-automl #4656

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Sep 14, 2023

Update CI config (#122)

73cd6d7

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

datastore: Namespace should be a dataset-level configuration #122

datastore: Namespace should be a dataset-level configuration #122

rakyll commented Aug 20, 2014

silvolu commented Aug 22, 2014

This comment was marked as spam.

rakyll commented Aug 26, 2014

rakyll commented Aug 26, 2014

stephenplusplus commented Aug 26, 2014

rakyll commented Aug 26, 2014

stephenplusplus commented Aug 26, 2014

rakyll commented Aug 27, 2014

datastore: Namespace should be a dataset-level configuration #122

datastore: Namespace should be a dataset-level configuration #122

Conversation

rakyll commented Aug 20, 2014

silvolu commented Aug 22, 2014

This comment was marked as spam.

rakyll commented Aug 26, 2014

rakyll commented Aug 26, 2014

stephenplusplus commented Aug 26, 2014

rakyll commented Aug 26, 2014

stephenplusplus commented Aug 26, 2014

rakyll commented Aug 27, 2014