-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: separate native-image-shared-config into its own module #712
Conversation
java-shared-config/pom.xml
Outdated
<developers> | ||
<developer> | ||
<id>chingor13</id> | ||
<name>Jeff Ching</name> | ||
<email>[email protected]</email> | ||
<organization>Google</organization> | ||
<roles> | ||
<role>Developer</role> | ||
</roles> | ||
</developer> | ||
</developers> | ||
<organization> | ||
<name>Google LLC</name> | ||
</organization> | ||
<scm> | ||
<connection>scm:git:[email protected]:googleapis/java-shared-config.git</connection> | ||
<developerConnection>scm:git:[email protected]:googleapis/java-shared-config.git | ||
</developerConnection> | ||
<url>https://github.com/googleapis/java-shared-config</url> | ||
<tag>HEAD</tag> | ||
</scm> | ||
|
||
<issueManagement> | ||
<url>https://github.com/googleapis/java-shared-config/issues</url> | ||
<system>GitHub Issues</system> | ||
</issueManagement> | ||
|
||
<distributionManagement> | ||
<snapshotRepository> | ||
<id>sonatype-nexus-snapshots</id> | ||
<url>https://google.oss.sonatype.org/content/repositories/snapshots</url> | ||
</snapshotRepository> | ||
<repository> | ||
<id>sonatype-nexus-staging</id> | ||
<url>https://google.oss.sonatype.org/service/local/staging/deploy/maven2/</url> | ||
</repository> | ||
</distributionManagement> | ||
|
||
<licenses> | ||
<license> | ||
<name>Apache-2.0</name> | ||
<url>https://www.apache.org/licenses/LICENSE-2.0.txt</url> | ||
</license> | ||
</licenses> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to move this section to the new root parent native-image-shared-config
, and it doesn't need to be duplicated here as it will be inherited.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, done. Moved this content from java-shared-config/pom.xml to native-image-shared-config/pom.xml and removed the duplicated content.
…onfig into native-artifact
Once you merge this "feat" pull request, check Release Please pull request has correct updates for the versions. |
Thank you @suztomo! Also the stage job ran successfully with this PR:
|
I'm surprised that publish_javadoc11.sh is involved with this repo since we aren't publishing documentation anywhere. It might be that this job is unnecessary. |
Piping in here - pretty sure all the Kokoro release jobs in this repo are obsolete as they were migrated to g3. See cl/533291527 |
native-image-shared-config
. A pom.xml file focused on native image is easier to maintain.native-image-shared-config
artifact is brought in as a parent ofjava-shared-config
mvn test -Pnative -Pnative-deps -Dtest=*Test
: