Skip to content

Commit

Permalink
feat: separate native-image-shared-config into its own module (#712)
Browse files Browse the repository at this point in the history
* feat: separate out native image shared configs into their own artifact
  • Loading branch information
mpeddada1 authored Nov 30, 2023
1 parent 328d0a4 commit 567fecb
Show file tree
Hide file tree
Showing 8 changed files with 955 additions and 825 deletions.
2 changes: 1 addition & 1 deletion .kokoro/client-library-check-javadoc-with-doclet.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ set -x
mvn install -DskipTests=true -Dmaven.javadoc.skip=true -Dgcloud.download.skip=true -B -V -q

# Read the current version of this BOM in the POM. Example version: '0.116.1-alpha-SNAPSHOT'
VERSION_POM=pom.xml
VERSION_POM=java-shared-config/pom.xml
# Namespace (xmlns) prevents xmllint from specifying tag names in XPath
VERSION=`sed -e 's/xmlns=".*"//' ${VERSION_POM} | xmllint --xpath '/project/version/text()' -`

Expand Down
2 changes: 1 addition & 1 deletion .kokoro/client-library-check.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ cd ${scriptDir}/..
mvn install -DskipTests=true -Dmaven.javadoc.skip=true -Dgcloud.download.skip=true -B -V -q
# Read the current version of this BOM in the POM. Example version: '0.116.1-alpha-SNAPSHOT'
VERSION_POM=pom.xml
VERSION_POM=java-shared-config/pom.xml
# Namespace (xmlns) prevents xmllint from specifying tag names in XPath
VERSION=`sed -e 's/xmlns=".*"//' ${VERSION_POM} | xmllint --xpath '/project/version/text()' -`
Expand Down
2 changes: 2 additions & 0 deletions .kokoro/verify-docker-images.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ scriptDir=$(realpath "$(dirname "${BASH_SOURCE[0]}")")
cd ${scriptDir}/.. || exit

# Fetch the java-shared-config version in source of the current commit.
pushd java-shared-config
javaSharedConfigVersion="$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout)"
popd

branchName=$(git name-rev "${KOKORO_GIT_COMMIT}" | sed 's/.* //')
gitCommitMessage=$(git log -1 "$(git rev-parse --short "${KOKORO_GIT_COMMIT}")" | grep "chore(main): release *")
Expand Down
15 changes: 15 additions & 0 deletions java-shared-config/java.header
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
^/\*$
^ \* Copyright \d\d\d\d,? Google (Inc\.|LLC)$
^ \*$
^ \* Licensed under the Apache License, Version 2\.0 \(the "License"\);$
^ \* you may not use this file except in compliance with the License\.$
^ \* You may obtain a copy of the License at$
^ \*$
^ \*[ ]+https?://www.apache.org/licenses/LICENSE-2\.0$
^ \*$
^ \* Unless required by applicable law or agreed to in writing, software$
^ \* distributed under the License is distributed on an "AS IS" BASIS,$
^ \* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied\.$
^ \* See the License for the specific language governing permissions and$
^ \* limitations under the License\.$
^ \*/$
10 changes: 10 additions & 0 deletions java-shared-config/license-checks.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?xml version="1.0"?>
<!DOCTYPE module PUBLIC
"-//Puppy Crawl//DTD Check Configuration 1.3//EN"
"http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
<module name="Checker">
<module name="RegexpHeader">
<property name="fileExtensions" value="java"/>
<property name="headerFile" value="${checkstyle.header.file}"/>
</module>
</module>
Loading

0 comments on commit 567fecb

Please sign in to comment.