samples: add publish with flow control sample #717
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
api: pubsub
|
|
||
| try { | ||
| // Configure how many messages the publisher client can hold in memory | ||
| // before publishing succeeds, and what to do when messages exceed the limit. |
There was a problem hiding this comment.
What do you mean by "before publishing succeeds?"
There was a problem hiding this comment.
Removed this clause.
|
|
||
| publisher = Publisher.newBuilder(topicName).setBatchingSettings(batchingSettings).build(); | ||
|
|
||
| // Publish 1000 messages in quick succession to trigger publisher flow control. |
There was a problem hiding this comment.
I wouldn't say "to trigger flow control." It's possible that flow control will be triggered, but it's also entirely possible it won't be if messages get out quickly enough. Either way, the fact that flow control was triggered isn't something that will be easily visible to the user. Maybe say "Rapidly publishing 1000 messages in a loop may be constrained by flow control."
There was a problem hiding this comment.
Updated. True, the user will only know for sure if they turn on logging.
For internal b/191088406