samples(pubsub): Add publisher flow control sample #12005
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
api: pubsub
|
The delete schema rpc is flaky and is a known issue. |
| @@ -290,6 +290,37 @@ def publish_messages_async_with_concurrency_control topic_id: | |||
| # [END pubsub_publisher_concurrency_control] | |||
| end | |||
|
|
|||
| def publish_messages_async_with_flow_control topic_id: | |||
| # [START pubsub_publisher_flow_control] | |||
| # topic_id = "your-topic-id" | |||
There was a problem hiding this comment.
I would put this line a bit further down, just above the topic = ... line where it is used, because that's where we'd expect to see it in actual code.
There was a problem hiding this comment.
This is the style throughout these samples, so it will be best not to change it in this PR.
There was a problem hiding this comment.
grrr... well, I guess I'll open an issue.
|
|
||
| topic = pubsub.topic topic_id, async: { | ||
| # Configure how many messages the publisher client can hold in memory | ||
| # before publishing succeeds, and what to do when messages exceed the limit. |
There was a problem hiding this comment.
What do you mean by "before publishing succeeds?"
| limit_exceeded_behavior: :block | ||
| } | ||
| } | ||
| # Publish 1000 messages in quick succession to trigger publisher flow control. |
There was a problem hiding this comment.
I wouldn't say "to trigger flow control." It's possible that flow control will be triggered, but it's also entirely possible it won't be if messages get out quickly enough. Either way, the fact that flow control was triggered isn't something that will be easily visible to the user. Maybe say "Rapidly publishing 1000 messages in a loop may be constrained by flow control."
|
CI error is delete_schema flake. |
closes: #11685
See also:
Java: googleapis/java-pubsub#717
Python: googleapis/python-pubsub#429