Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove org.jspecify dependency #1362

Closed
losalex opened this issue Jun 6, 2023 · 0 comments · Fixed by #1364
Closed

fix: Remove org.jspecify dependency #1362

losalex opened this issue Jun 6, 2023 · 0 comments · Fixed by #1364
Assignees
@losalex
Labels
api: logging Issues related to the googleapis/java-logging API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@losalex
Copy link
Contributor

losalex commented Jun 6, 2023

Based on https://github.com/jspecify/jspecify#readme, the usage of the org.jspecify annotations are not recommended in release libraries, so it needs to be removed from code for now.
@losalex losalex added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jun 6, 2023
@losalex losalex self-assigned this Jun 6, 2023
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Jun 6, 2023
@losalex losalex mentioned this issue Jun 6, 2023
Merged
cpovirk added a commit to cpovirk/java-logging that referenced this issue Oct 15, 2024
@cpovirk
Reintroduce JSpecify annotations.
29a7b06 
JSpecify 1.0.0 has been released, so I'm hoping that
googleapis#1362 is no longer a
concern. (If there are remaining concerns, please do let me know.)

This reverts commit 8138f46 (aka
googleapis#1364) with a few
changes:

- This commit uses JSpecify 1.0.0 instead of 0.2.0.
- As a result, it uses `org.jspecify.annotations` instead of
  `org.jspecify.nullness`.
- It no longer touches `Structs`, since that was deleted in
  googleapis#1501.
@cpovirk cpovirk mentioned this issue Oct 15, 2024
Open
cpovirk added a commit to cpovirk/java-logging that referenced this issue Oct 15, 2024
@cpovirk
fix: Reintroduce JSpecify annotations.
c3f02dc 
JSpecify 1.0.0 has been released, so I'm hoping that
googleapis#1362 is no longer a
concern. (If there are remaining concerns, please do let me know.)

This reverts commit 8138f46 (aka
googleapis#1364) with a few
changes:

- This commit uses JSpecify 1.0.0 instead of 0.2.0.
- As a result, it uses `org.jspecify.annotations` instead of
  `org.jspecify.nullness`.
- It no longer touches `Structs`, since that was deleted in
  googleapis#1501.

(JSpecify annotations were originally introduced by
googleapis#1010.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@losalex losalex

Labels
api: logging Issues related to the googleapis/java-logging API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove org.jspecify dependency googleapis/java-logging
1 participant
@losalex