Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(storage): Add ARCHIVE storage class #4319

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

quartzmo
Copy link
Member

  • Update some storage class testing to use ARCHIVE.

[closes #4285]

* Update some storage class testing to use ARCHIVE.

[closes googleapis#4285]
@quartzmo quartzmo self-assigned this Oct 30, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 30, 2019
@quartzmo quartzmo added api: storage Issues related to the Cloud Storage API. type: docs Improvement to the documentation for an API. labels Oct 30, 2019
@quartzmo quartzmo requested a review from tritone October 30, 2019 15:15
Copy link

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

We should hold off on merging until the feature is no longer behind a flag (may be a while based on a meeting I went to today). I will keep you posted.

@quartzmo quartzmo added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 30, 2019
@tritone
Copy link

tritone commented Dec 27, 2019

@quartzmo @JesseLovelace @frankyn -- we are now no longer blocked on this. This change should be merged whenever possible, and then released once the release freeze has ended (between 1/2 and 1/8). Let me know if there are any issues with this plan. Thanks!

@quartzmo
Copy link
Member Author

@tritone Plan sounds good, will do!

@quartzmo quartzmo removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 27, 2019
@quartzmo quartzmo merged commit 857b530 into googleapis:master Jan 6, 2020
@quartzmo quartzmo deleted the storage-class-archive branch January 6, 2020 18:48
@quartzmo
Copy link
Member Author

quartzmo commented Jan 6, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage: Add support for archive storage class
3 participants