docs(firestore): clarify client threadsafety #9254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HemangChothani
requested review from
crwilcox,
frankyn and
tseaver
as code owners
googlebot
added
the
cla: yes
HemangChothani
changed the title
tseaver
suggested changes
Sep 25, 2019
firestore/docs/index.rst
Outdated
| @@ -1,5 +1,12 @@ | |||
| .. include:: README.rst | |||
|
|
|||
| .. note:: | |||
|
|
|||
| Because the firestore client uses :mod:`grpc` library and the third-party | |||
There was a problem hiding this comment.
Firestore doesn't use requests at all. We should refer to the gRPC library using its PyPI name, e.g., grpcio.
tseaver
changed the title
MaxxleLLC
force-pushed
the
Firestore_Add_docs_regarding_Client_threadsafety_7421
branch
from
14bba54 to
b35cf7d
Compare
HemangChothani
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
tseaver
approved these changes
Oct 8, 2019
crwilcox
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7421