Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: Add docs regarding Client threadsafety #7421

Closed
danielx opened this issue Feb 22, 2019 · 1 comment · Fixed by #9254
Closed

Firestore: Add docs regarding Client threadsafety #7421

danielx opened this issue Feb 22, 2019 · 1 comment · Fixed by #9254
Assignees
@crwilcox
Labels
api: firestore Issues related to the Firestore API. type: docs Improvement to the documentation for an API.

Comments

@danielx
Copy link

danielx commented Feb 22, 2019

Is your feature request related to a problem? Please describe.
There is no mention in the current docs if a google.cloud.firestore.Client() can safely be shared among threads.

Describe the solution you'd like
Some docs explaining if a Client can safely be reused among threads.
@tseaver tseaver added api: firestore Issues related to the Firestore API. type: docs Improvement to the documentation for an API. labels Feb 22, 2019
@tseaver
Copy link
Contributor

tseaver commented Feb 22, 2019

For example, see storage/docs/index.rst. We should do likewise for all clients.

@HemangChothani HemangChothani mentioned this issue Sep 20, 2019
Merged
@cmur2 cmur2 mentioned this issue Jun 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crwilcox crwilcox

Labels
api: firestore Issues related to the Firestore API. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(firestore): clarify client threadsafety MaxxleLLC/google-cloud-python
3 participants
@tseaver @crwilcox @danielx