-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage: Restrict version range of google-resumable-media. #9242
Conversation
b129833
to
508c6e7
Compare
@@ -31,7 +31,7 @@ | |||
dependencies = [ | |||
"google-auth >= 1.2.0", | |||
"google-cloud-core >= 1.0.3, < 2.0dev", | |||
"google-resumable-media >= 0.4.0", | |||
"google-resumable-media >= 0.3.1, < 0.5.0dev", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a match to the manually released 1.19.1
We can rev this to 0.4.0 since this was an unreleased change
@tseaver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"google-resumable-media >= 0.3.1, < 0.5.0dev", | |
"google-resumable-media >= 0.4.0, < 0.5.0dev", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ISTM that >= 0.3.1, != 0.4.0, < 0.5dev
is the right specification, until GRMP has a new version (might be 1.0.0
?) to include deliberately: the reality is that 0.3.1
and 0.4.1
are near identical, and the storage client works with the older one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR needs the test change reversion, already in #9240. I recommend closing here, and adding a PR which updates the changelog separately.
Superseded by #9240. |
No description provided.