Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage: Revert "Fix tests b0rken by 'google-resumable-media 0.4.0' release." #9240

Merged
merged 3 commits into from
Sep 18, 2019
Merged

Storage: Revert "Fix tests b0rken by 'google-resumable-media 0.4.0' release." #9240

merged 3 commits into from
Sep 18, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 17, 2019

Reverts #9204

Should fix tests for #9239.

@tseaver tseaver added the api: storage Issues related to the Cloud Storage API. label Sep 17, 2019
@tseaver tseaver requested a review from frankyn as a code owner September 17, 2019 20:44
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 17, 2019
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2019
@tseaver
Copy link
Contributor Author

tseaver commented Sep 17, 2019

@busunkim96 I've just pushed a change which excludes the problematic google-resumable-media 0.4.0 release (just in case).

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2019
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 18, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 18, 2019
@tseaver
Copy link
Contributor Author

tseaver commented Sep 18, 2019

New flaky storage systest tracked in #9247.

@tseaver tseaver merged commit f129701 into master Sep 18, 2019
@tseaver tseaver deleted the revert-9204-storage-fix-tests-for-grmp-0.4 branch September 18, 2019 17:26
@tseaver tseaver mentioned this pull request Sep 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

@frankyn frankyn Awaiting requested review from frankyn

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @busunkim96 @googlebot @yoshi-kokoro