Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move table and dataset snippets to samples/ directory #7683

Merged
merged 4 commits into from
Apr 10, 2019
Merged

Move table and dataset snippets to samples/ directory #7683

merged 4 commits into from
Apr 10, 2019

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Apr 9, 2019 •
edited
Loading

These samples follow the same pattern as the Models API samples, following our rubric guidelines for 1 sample per file.

This work was completed by @lbristol88 and reviewed on my personal fork, as the Models API PR hadn't yet merged when she started this work.

@tswast tswast added api: bigquery Issues related to the BigQuery API. type: docs Improvement to the documentation for an API. labels Apr 9, 2019
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Apr 9, 2019
@sduskis sduskis added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Apr 9, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Apr 10, 2019
@tswast tswast added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Apr 10, 2019
@tswast tswast marked this pull request as ready for review April 10, 2019 18:12
@tswast tswast requested a review from crwilcox as a code owner April 10, 2019 18:12
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 10, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 10, 2019
@lbristol88 @tswast
Move create table sample to samples directory
46903de 
* Add `samples/create_table.py` sample code.

* Remove `test_create_table` from snippets collection.
@lbristol88 @tswast
Move code sample for create dataset to samples directory (#5)
92fd8af
@lbristol88 @tswast
Added collection of Managing Dataset samples (#6)
32e43a9 
* Added delete dataset function

* Added get dataset function

* Added list dataset function

* Added update dataset description sample

* Added update dataset access sample

* Added update dataset table expiration sample

* Added tests for dataset samples and updated docs

* Removing original update dataset access from snippets file.

* Moved all dataset tests into own file. Made changes based on feedback.

* Made changes based on feedback

* Removed unnecessary use of random_dataset_id in tests and removed one_day_ms fixture

* Removed unnecessary constant

* Stored the math as a constant to make it look cleaner.
@lbristol88 @tswast
Wrapping up a few Managing Table samples (#7)
8724e87 
* Updated list tables snippet along with test.

* Removed old list table snippet and upated location of sample
@tswast tswast force-pushed the bq-snippets-rebased branch from 094602b to 8724e87 Compare April 10, 2019 18:15
@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Apr 10, 2019
@tswast tswast added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Apr 10, 2019
@googleapis googleapis deleted a comment from googlebot Apr 10, 2019
@googleapis googleapis deleted a comment from googlebot Apr 10, 2019
@googleapis googleapis deleted a comment from googlebot Apr 10, 2019
@googleapis googleapis deleted a comment from googlebot Apr 10, 2019
@tswast tswast requested review from shollyman and steffnay April 10, 2019 18:17
@tswast tswast merged commit 7ba0220 into googleapis:master Apr 10, 2019
@tswast tswast deleted the bq-snippets-rebased branch April 10, 2019 20:19
tswast added a commit to tswast/google-cloud-python that referenced this pull request Apr 11, 2019
@tswast
Move table and dataset snippets to samples/ directory (googleapis#7683)
7124c60 
* Move create table sample to samples directory

These samples follow the same pattern as the Models API samples, following our rubric guidelines for 1 sample per file.

This work was completed by Layla and reviewed on Tim's personal fork, as the Models API PR hadn't yet merged when she started this work.
@tswast tswast mentioned this pull request Aug 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

@shollyman shollyman Awaiting requested review from shollyman

@steffnay steffnay Awaiting requested review from steffnay

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tswast @googlebot @sduskis @yoshi-kokoro @lbristol88