Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery: deprecate client.dataset() #8989

Closed
tswast opened this issue Aug 7, 2019 · 3 comments · Fixed by #7753
Closed

BigQuery: deprecate client.dataset() #8989

tswast opened this issue Aug 7, 2019 · 3 comments · Fixed by #7753
Assignees
Labels
api: bigquery Issues related to the BigQuery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tswast
Copy link
Contributor

tswast commented Aug 7, 2019

See: #7753

We should recommend the simpler "use a string instead of a reference object" in most cases.

We still call .dataset() 96 times in our samples at docs/snippets.py. I would feel better about adding the deprecation notice after we update the rest of our samples.

@tswast tswast added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: bigquery Issues related to the BigQuery API. labels Aug 7, 2019
@tswast
Copy link
Contributor Author

tswast commented Aug 7, 2019

As part of these sample updates, I'd also like to move the snippets to their own sample files in the samples/ directory. See: #7683 for examples.

@tswast
Copy link
Contributor Author

tswast commented Aug 7, 2019

/CC @emar-kar @IlyaFaer

@IlyaFaer IlyaFaer self-assigned this Aug 8, 2019
@IlyaFaer
Copy link

IlyaFaer commented Aug 8, 2019

@tswast, taken to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
4 participants