Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: add 'Collection.list_documents' method. #7221

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Firestore: add 'Collection.list_documents' method. #7221

merged 1 commit into from
Feb 1, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jan 29, 2019

Closes #6545.

@tseaver tseaver added the api: firestore Issues related to the Firestore API. label Jan 29, 2019
@tseaver tseaver requested a review from crwilcox January 29, 2019 22:49
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 29, 2019
crwilcox
crwilcox reviewed Feb 1, 2019
View reviewed changes
firestore/google/cloud/firestore_v1beta1/collection.py
Args:
page_size (Optional[int]]): The maximum number of documents
in each page of results from this request. Non-positive values
are ignored. Defaults to a sensible value set by the API.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did you find this mentioned? I tried to find an actual sort of value here, but really page_size is a maximum, not a prescribed size. I am imagining there is an actual max? I guess I just don't like saying "it's magic"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I am still unsure of this exact value. I will leave it up to you if we want "Defaults to a sensible value set by the API". it is true, I just don't like not knowing the answer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no documented number.

@tseaver tseaver merged commit f946a21 into googleapis:master Feb 1, 2019
@tseaver tseaver deleted the 6545-firestore-add_collection_ref_list_doucments branch February 1, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox crwilcox approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @crwilcox @googlebot