Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Firestore] Add list documents method to CollectionReference #6545

Closed
crwilcox opened this issue Nov 16, 2018 · 2 comments
Closed

[Firestore] Add list documents method to CollectionReference #6545

crwilcox opened this issue Nov 16, 2018 · 2 comments
Assignees
@tseaver
Labels
api: firestore Issues related to the Firestore API. triaged for GA type: process A process-related concern. May include testing, release, or the like.

Comments

@crwilcox
Copy link
Contributor

crwilcox commented Nov 16, 2018 •
edited
Loading

CollectionReference.listDocuments() is missing.
This is new feature request and only available in Node, Java and Go so far.
@crwilcox crwilcox added api: firestore Issues related to the Firestore API. triaged for GA labels Nov 16, 2018
@tseaver
Copy link
Contributor

tseaver commented Nov 16, 2018

How is this different than CollectionReference.get, which returns an iterable of DocumentSnapshots in the collection?

@schmidt-sebastian
Copy link

schmidt-sebastian commented Nov 16, 2018 •
edited
Loading

listDocuments() should use the ListDocumentRpc, which showMissing set to true. This will include missing documents (documents that don't themselves exist but have subcollections). These documents are not returned by the Query API, which makes traversing the full set of data in a database impossible if there are such missing documents.
Furthermore, we only want to return DocumentReferences.

@JustinBeckwith JustinBeckwith added the triage me I really want to be triaged. label Nov 17, 2018
@tseaver tseaver added the type: process A process-related concern. May include testing, release, or the like. label Nov 19, 2018
@JustinBeckwith JustinBeckwith removed the triage me I really want to be triaged. label Nov 19, 2018
@crwilcox crwilcox assigned mcdonc and unassigned mcdonc Jan 15, 2019
@tseaver tseaver assigned tseaver and unassigned mcdonc Jan 29, 2019
@tseaver tseaver mentioned this issue Jan 29, 2019
Merged
tseaver added a commit that referenced this issue Feb 1, 2019
@tseaver
Add 'Collection.list_documents' method. (#7221)
f946a21 
Closes #6545.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: firestore Issues related to the Firestore API. triaged for GA type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mcdonc @tseaver @JustinBeckwith @crwilcox @schmidt-sebastian